Fix some missing includes.

hzeller · hzeller · commit 9d9f5b118fdd · 2026-04-14T02:55:45.000-07:00
And sort the headers in the affected files according to style guide.

Breakdown
```
util/RiseFallMinMax.cc:                  #include "MinMax.hh" for sta::MinMaxAll
sdc/Variables.cc:                        #include "PocvMode.hh" for sta::PocvMode
sdc/PortExtCap.cc:                       #include "NetworkClass.hh" for sta::Port
util/ReportTcl.cc:                       #include "Report.hh" for sta::Report
util/RiseFallMinMaxDelay.cc:             #include "StaState.hh" for sta::StaState
util/RiseFallMinMax.cc:                  #include "Transition.hh" for sta::RiseFallBoth
util/RiseFallValues.cc:                  #include "Transition.hh" for sta::RiseFallBoth
sdc/PortExtCap.cc:                       #include "MinMax.hh" for sta::MinMax
util/RiseFallMinMaxDelay.cc:             #include "MinMax.hh" for sta::MinMax
dcalc/DelayNormal.cc:                    #include "Delay.hh" for sta::Delay
dcalc/DelayScalar.cc:                    #include "Delay.hh" for sta::Delay
dcalc/DelaySkewNormal.cc:                #include "Delay.hh" for sta::Delay
util/RiseFallMinMaxDelay.cc:             #include "Delay.hh" for sta::Delay
dcalc/Delay.cc:                          #include "MinMax.hh" for sta::EarlyLate
dcalc/DelayNormal.cc:                    #include "MinMax.hh" for sta::EarlyLate
dcalc/DelayScalar.cc:                    #include "MinMax.hh" for sta::EarlyLate
dcalc/DelaySkewNormal.cc:                #include "MinMax.hh" for sta::EarlyLate
sdc/PortExtCap.cc:                       #include "Transition.hh" for sta::RiseFall
util/RiseFallMinMaxDelay.cc:             #include "Transition.hh" for sta::RiseFall
util/MinMax.cc:                          #include &lt;array&gt; for std::array
util/Transition.cc:                      #include &lt;array&gt; for std::array
power/VcdParse.cc:                       #include &lt;stdexcept&gt; for std::invalid_argument
dcalc/FindRoot.cc:                       #include &lt;utility&gt; for std::pair
util/StringUtil.cc:                      #include &lt;utility&gt; for std::pair
dcalc/Delay.cc:                          #include &lt;string&gt; for std::string
dcalc/DelayNormal.cc:                    #include &lt;string&gt; for std::string
dcalc/DelayScalar.cc:                    #include &lt;string&gt; for std::string
dcalc/DelaySkewNormal.cc:                #include &lt;string&gt; for std::string
liberty/Units.cc:                        #include &lt;string&gt; for std::string
network/VerilogNamespace.cc:             #include &lt;string&gt; for std::string
power/VcdParse.cc:                       #include &lt;string&gt; for std::string
search/PocvMode.cc:                      #include &lt;string&gt; for std::string
util/Error.cc:                           #include &lt;string&gt; for std::string
util/PatternMatch.cc:                    #include &lt;string&gt; for std::string
util/Report.cc:                          #include &lt;string&gt; for std::string
util/StringUtil.cc:                      #include &lt;string&gt; for std::string
util/Transition.cc:                      #include &lt;string&gt; for std::string
dcalc/ArnoldiDelayCalc.cc:               #include "Error.hh" for criticalError
search/GatedClk.cc:                      #include "Error.hh" for criticalError
search/Levelize.cc:                      #include "Error.hh" for criticalError
util/Report.cc:                          #include &lt;cstdio&gt; for printf
util/MachineWin32.cc:                    #include &lt;cstdarg&gt; for va_list
```

Signed-off-by: Henner Zeller &lt;h.zeller@acm.org&gt;
diff --git a/dcalc/ArnoldiDelayCalc.cc b/dcalc/ArnoldiDelayCalc.cc
@@ -31,25 +31,26 @@
 #include <cstdio>
 #include <cmath> // abs
 
-#include "Report.hh"
+#include "ArcDelayCalc.hh"
+#include "Arnoldi.hh"
+#include "ArnoldiReduce.hh"
 #include "Debug.hh"
-#include "Units.hh"
+#include "DelayCalc.hh"
+#include "Error.hh"
+#include "Graph.hh"
+#include "GraphDelayCalc.hh"
 #include "Liberty.hh"
-#include "TimingModel.hh"
-#include "TimingArc.hh"
-#include "TableModel.hh"
-#include "PortDirection.hh"
+#include "LumpedCapDelayCalc.hh"
 #include "Network.hh"
-#include "Graph.hh"
 #include "Parasitics.hh"
+#include "PortDirection.hh"
+#include "Report.hh"
 #include "Sdc.hh"
-#include "DelayCalc.hh"
-#include "ArcDelayCalc.hh"
-#include "LumpedCapDelayCalc.hh"
-#include "GraphDelayCalc.hh"
+#include "TableModel.hh"
+#include "TimingArc.hh"
+#include "TimingModel.hh"
+#include "Units.hh"
 #include "Variables.hh"
-#include "Arnoldi.hh"
-#include "ArnoldiReduce.hh"
 
 namespace sta {
 
diff --git a/dcalc/Delay.cc b/dcalc/Delay.cc
@@ -25,11 +25,13 @@
 #include "Delay.hh"
 
 #include <cmath>
+#include <string>
 
-#include "StaConfig.hh"
 #include "Fuzzy.hh"
-#include "Units.hh"
+#include "MinMax.hh"
+#include "StaConfig.hh"
 #include "StaState.hh"
+#include "Units.hh"
 #include "Variables.hh"
 
 namespace sta {
diff --git a/dcalc/DelayNormal.cc b/dcalc/DelayNormal.cc
@@ -25,12 +25,15 @@
 #include "DelayNormal.hh"
 
 #include <cmath> // sqrt
+#include <string>
 
+#include "Delay.hh"
 #include "Error.hh"
-#include "Fuzzy.hh"
-#include "Units.hh"
 #include "Format.hh"
+#include "Fuzzy.hh"
+#include "MinMax.hh"
 #include "StaState.hh"
+#include "Units.hh"
 #include "Variables.hh"
 
 namespace sta {
diff --git a/dcalc/DelayScalar.cc b/dcalc/DelayScalar.cc
@@ -25,10 +25,13 @@
 // Delay as floats, non-SSTA.
 
 #include "DelayScalar.hh"
+#include <string>
 
+#include "Delay.hh"
 #include "Fuzzy.hh"
-#include "Units.hh"
+#include "MinMax.hh"
 #include "StaState.hh"
+#include "Units.hh"
 
 namespace sta {
 
diff --git a/dcalc/DelaySkewNormal.cc b/dcalc/DelaySkewNormal.cc
@@ -25,12 +25,15 @@
 #include "DelaySkewNormal.hh"
 
 #include <cmath> // sqrt
+#include <string>
 
+#include "Delay.hh"
 #include "Error.hh"
-#include "Fuzzy.hh"
-#include "Units.hh"
 #include "Format.hh"
+#include "Fuzzy.hh"
+#include "MinMax.hh"
 #include "StaState.hh"
+#include "Units.hh"
 #include "Variables.hh"
 
 namespace sta {
diff --git a/dcalc/FindRoot.cc b/dcalc/FindRoot.cc
@@ -25,6 +25,7 @@
 #include "FindRoot.hh"
 
 #include <cmath> // abs
+#include <utility>
 
 namespace sta {
 
diff --git a/include/sta/PowerClass.hh b/include/sta/PowerClass.hh
@@ -24,6 +24,7 @@
 
 #pragma once
 
+#include <string>
 #include <vector>
 #include <utility>
 
@@ -94,6 +95,7 @@ private:
   float leakage_{0.0};
 };
 
+class Instance;
 using InstPower = std::pair<const Instance*, PowerResult>;
 using InstPowers = std::vector<InstPower>;
 
diff --git a/liberty/LibExprReaderPvt.hh b/liberty/LibExprReaderPvt.hh
@@ -24,6 +24,7 @@
 
 #pragma once
 
+#include <cstddef>
 #include <string>
 #include <string_view>
 
diff --git a/liberty/Units.cc b/liberty/Units.cc
@@ -25,11 +25,12 @@
 #include "Units.hh"
 
 #include <cmath> // abs
+#include <string>
 
 #include "Format.hh"
-#include "StringUtil.hh"
-#include "MinMax.hh"  // INF
 #include "Fuzzy.hh"
+#include "MinMax.hh"  // INF
+#include "StringUtil.hh"
 
 namespace sta {
 
diff --git a/network/VerilogNamespace.cc b/network/VerilogNamespace.cc
@@ -25,9 +25,10 @@
 #include "VerilogNamespace.hh"
 
 #include <cctype>
+#include <string>
 
-#include "StringUtil.hh"
 #include "ParseBus.hh"
+#include "StringUtil.hh"
 
 namespace sta {
 
diff --git a/parasitics/SpefScanner.hh b/parasitics/SpefScanner.hh
@@ -27,6 +27,7 @@
 #include <string_view>
 
 #include "SpefLocation.hh"
+#include "SpefReaderPvt.hh"
 #include "SpefParse.hh"
 
 #ifndef __FLEX_LEXER_H
diff --git a/power/SaifScanner.hh b/power/SaifScanner.hh
@@ -25,6 +25,7 @@
 #pragma once
 
 #include "SaifLocation.hh"
+#include "SaifReaderPvt.hh"
 #include "SaifParse.hh"
 
 #ifndef __FLEX_LEXER_H
diff --git a/power/VcdParse.cc b/power/VcdParse.cc
@@ -27,11 +27,13 @@
 #include <algorithm>
 #include <cctype>
 #include <cinttypes>
+#include <stdexcept>
+#include <string>
 
-#include "Stats.hh"
-#include "Report.hh"
-#include "Error.hh"
 #include "EnumNameMap.hh"
+#include "Error.hh"
+#include "Report.hh"
+#include "Stats.hh"
 
 namespace sta {
 
diff --git a/sdc/PortExtCap.cc b/sdc/PortExtCap.cc
@@ -23,6 +23,9 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "PortExtCap.hh"
+#include "MinMax.hh"
+#include "NetworkClass.hh"
+#include "Transition.hh"
 
 namespace sta {
 
diff --git a/sdc/Variables.cc b/sdc/Variables.cc
@@ -23,6 +23,7 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "Variables.hh"
+#include "PocvMode.hh"
 
 namespace sta {
 
diff --git a/sdf/SdfScanner.hh b/sdf/SdfScanner.hh
@@ -27,6 +27,7 @@
 #include <string_view>
 
 #include "SdfLocation.hh"
+#include "SdfReaderPvt.hh"
 #include "SdfParse.hh"
 
 #ifndef __FLEX_LEXER_H
diff --git a/search/GatedClk.cc b/search/GatedClk.cc
@@ -25,6 +25,7 @@
 #include "GatedClk.hh"
 
 #include "ClkNetwork.hh"
+#include "Error.hh"
 #include "FuncExpr.hh"
 #include "Graph.hh"
 #include "Liberty.hh"
diff --git a/search/Levelize.cc b/search/Levelize.cc
@@ -30,6 +30,7 @@
 
 #include "ContainerHelpers.hh"
 #include "Debug.hh"
+#include "Error.hh"
 #include "Graph.hh"
 #include "GraphCmp.hh"
 #include "GraphDelayCalc.hh"
diff --git a/search/PocvMode.cc b/search/PocvMode.cc
@@ -23,6 +23,7 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "PocvMode.hh"
+#include <string>
 
 #include "EnumNameMap.hh"
 
diff --git a/util/Error.cc b/util/Error.cc
@@ -26,6 +26,7 @@
 
 #include <cstdio>
 #include <cstdlib>
+#include <string>
 
 #include "Format.hh"
 #include "StringUtil.hh"
diff --git a/util/MachineWin32.cc b/util/MachineWin32.cc
@@ -24,6 +24,7 @@
 
 #include "Machine.hh"
 
+#include <cstdarg>
 #include <cstdio>
 #include <windows.h> // GetSystemInfo
 
diff --git a/util/MinMax.cc b/util/MinMax.cc
@@ -25,6 +25,7 @@
 #include "MinMax.hh"
 
 #include <algorithm>
+#include <array>
 #include <limits>
 
 #include "StringUtil.hh"
diff --git a/util/PatternMatch.cc b/util/PatternMatch.cc
@@ -24,8 +24,9 @@
 
 #include "PatternMatch.hh"
 
-#include <cctype>
 #include <tcl.h>
+#include <cctype>
+#include <string>
 
 namespace sta {
 
diff --git a/util/Report.cc b/util/Report.cc
@@ -26,7 +26,9 @@
 
 #include <algorithm>  // min
 #include <cstdlib>    // exit
+#include <cstdio>
 #include <cstring>    // strlen
+#include <string>
 
 #include "Error.hh"
 #include "Format.hh"
diff --git a/util/ReportTcl.cc b/util/ReportTcl.cc
@@ -23,6 +23,7 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "ReportTcl.hh"
+#include "Report.hh"
 
 #include <cstdio>
 #include <cstdlib>
diff --git a/util/RiseFallMinMax.cc b/util/RiseFallMinMax.cc
@@ -23,6 +23,8 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "RiseFallMinMax.hh"
+#include "MinMax.hh"
+#include "Transition.hh"
 
 namespace sta {
 
diff --git a/util/RiseFallMinMaxDelay.cc b/util/RiseFallMinMaxDelay.cc
@@ -23,6 +23,10 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "RiseFallMinMaxDelay.hh"
+#include "Delay.hh"
+#include "MinMax.hh"
+#include "StaState.hh"
+#include "Transition.hh"
 
 namespace sta {
 
diff --git a/util/RiseFallValues.cc b/util/RiseFallValues.cc
@@ -23,6 +23,7 @@
 // This notice may not be removed or altered from any source distribution.
 
 #include "RiseFallValues.hh"
+#include "Transition.hh"
 
 namespace sta {
 
diff --git a/util/StringUtil.cc b/util/StringUtil.cc
@@ -27,7 +27,9 @@
 #include <algorithm>
 #include <cctype>
 #include <charconv>
+#include <string>
 #include <system_error>
+#include <utility>
 #include <version>
 
 namespace sta {
diff --git a/util/Transition.cc b/util/Transition.cc
@@ -25,6 +25,8 @@
 #include "Transition.hh"
 
 #include <algorithm>
+#include <array>
+#include <string>
 
 #include "ContainerHelpers.hh"
 
diff --git a/verilog/VerilogReaderPvt.hh b/verilog/VerilogReaderPvt.hh
@@ -30,6 +30,7 @@
 #include <map>
 
 #include "StringUtil.hh"
+#include "VerilogReader.hh"
 
 namespace sta {
 
