clang-tidy applied and CMake installation of the single header added #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers were wrong. Applied some linter suggestions. There are still many left.
CMake can now install the single header. Removed an unneeded header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages already describe it.
The first commit does minor fixes suggested by clang-tidy which includes changing the headers. There are still many recommendation left but would require too much change which the owner needs to decide.
The second commit adds an installation of the single header. The problem is that headers like
<inja/environment.hpp>themselves cannot be included because headers are missing. The library only works when including<inja/inja.hpp>or the single header.All tests pass.
The project structure is really odd in a way that it does not include dependencies as headers but assumes that they are resolved by headers that include them which breaks the source code when the original files like
<inja/environment.hpp>are included directly. I tried to solve this but then you will end up with circular dependencies. This should really change.I am the packager for the AUR and these commits are needed so I would be very greatful if this gets approved.
Grüße aus Deutschland nach Deutschland.