Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy applied and CMake installation of the single header added #287

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

Spixmaster
Copy link
Contributor

@Spixmaster Spixmaster commented Mar 10, 2024

The commit messages already describe it.

The first commit does minor fixes suggested by clang-tidy which includes changing the headers. There are still many recommendation left but would require too much change which the owner needs to decide.

The second commit adds an installation of the single header. The problem is that headers like <inja/environment.hpp> themselves cannot be included because headers are missing. The library only works when including <inja/inja.hpp> or the single header.

All tests pass.

The project structure is really odd in a way that it does not include dependencies as headers but assumes that they are resolved by headers that include them which breaks the source code when the original files like <inja/environment.hpp> are included directly. I tried to solve this but then you will end up with circular dependencies. This should really change.

I am the packager for the AUR and these commits are needed so I would be very greatful if this gets approved.

Grüße aus Deutschland nach Deutschland.

Spixmaster and others added 3 commits March 9, 2024 15:34
Headers were wrong.
Applied some linter suggestions. There are still many left.
CMake can now install the single header.
Removed an unneeded header.
@pantor pantor merged commit 92994be into pantor:main Oct 5, 2024
15 checks passed
@pantor
Copy link
Owner

pantor commented Oct 5, 2024

Thanks so much for the PR and packaging inja! The project structure is indeed odd, and for sure I wouldn't do it the same way nowadays. I hope I'll find the time to update it soon.

Grüße zurück ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants