Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable json type #214

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

configurable json type #214

wants to merge 3 commits into from

Conversation

mathisloge
Copy link

This is the implementation of #213

Currently there is one breaking thing in the code base.

If you choose nlohmann::ordered_json the pointer

json* current_loop_data = &json_additional_data["loop"];
will get invalidated each time a new key was added.

There are two possible ways to fix that, either update the pointer each time json_additional_data is modified or decouple current_loop_data from json_additional_data.

@eadlam
Copy link

eadlam commented Sep 20, 2022

@mathisloge / @pantor, I could really use this feature. How hard do you think this is to finish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants