Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input clearable #687

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Fix input clearable #687

merged 6 commits into from
Feb 4, 2025

Conversation

aesteves60
Copy link
Contributor

No description provided.

@aesteves60 aesteves60 requested a review from a team as a code owner January 27, 2025 15:26
dpellier

This comment was marked as resolved.

Sign in to view

feoche
feoche requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@feoche feoche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Setting "0" value in type="number" does not show isClearable button
  • Setting type="number" in Demo after inputting a char in type="text" mode clears the field content, yet the isClearable button exist

@dpellier dpellier merged commit 4e00af2 into master Feb 4, 2025
9 checks passed
@dpellier dpellier deleted the fix-input-clearable branch February 4, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpellier dpellier dpellier approved these changes

@feoche feoche feoche approved these changes

@astagnol astagnol astagnol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aesteves60 @dpellier @feoche @astagnol