fix(input): test with input number type letter

Signed-off-by: Alexandre Esteves <[email protected]>
ovh · Jan 30, 2025 · 2b1ebcd · 2b1ebcd
1 parent ebaf0b7
commit 2b1ebcd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 14 deletions.
diff --git a/packages/ods/src/components/datepicker/src/components/ods-datepicker/ods-datepicker.tsx b/packages/ods/src/components/datepicker/src/components/ods-datepicker/ods-datepicker.tsx
@@ -331,7 +331,7 @@ export class OdsDatepicker implements OdsFormElement {
   }
 
   private onInput(event: InputEvent): void {
-    this.showClearable = !(event.target as HTMLInputElement).value;
+    this.showClearable = !!(event.target as HTMLInputElement).value;
   }
 
   render(): FunctionalComponent {

diff --git a/packages/ods/src/components/datepicker/tests/rendering/ods-datepicker.e2e.ts b/packages/ods/src/components/datepicker/tests/rendering/ods-datepicker.e2e.ts
@@ -177,7 +177,7 @@ describe('ods-datepicker rendering', () => {
     });
 
     it('should render clearable button when type wrong format', async() => {
-      await setup('<ods-datepicker is-clearable ></ods-datepicker>');
+      await setup('<ods-datepicker is-clearable></ods-datepicker>');
 
       await el.type('clearable');
       await page.waitForChanges();

diff --git a/packages/ods/src/components/input/src/components/ods-input/ods-input.tsx b/packages/ods/src/components/input/src/components/ods-input/ods-input.tsx
@@ -260,13 +260,6 @@ export class OdsInput implements OdsFormElement {
       this.shouldUpdateIsInvalidState = false;
     }
 
-    // console.log('this.internals.validity', this.internals.validity)
-    // if (!this.internals.validity?.valid && !this.internals.validity?.valueMissing) {
-    //   this.showClearable = true;
-    // } else {
-    //   this.showClearable = false;
-    // }
-
     this.odsChange.emit({
       name: this.name,
       previousValue: typeof this.value === 'number' && isNumeric(previousValue) ? Number(previousValue) : previousValue,

diff --git a/packages/ods/src/components/input/tests/rendering/ods-input.e2e.ts b/packages/ods/src/components/input/tests/rendering/ods-input.e2e.ts
@@ -268,11 +268,11 @@ describe('ods-input rendering', () => {
       expect(buttonClearable).toBeNull();
 
       // Test E2E launched with chrome. Chrome don't allow to type on input type number
-      // await page.keyboard.press('q');
-      // await page.waitForChanges();
-      // await new Promise(resolve => setTimeout(resolve, 20000));
-      // buttonClearable = await page.find('ods-input >>> ods-button[icon="xmark"]');
-      // expect(buttonClearable).not.toBeNull();
+      await page.keyboard.press('e');
+      await page.waitForChanges();
+
+      buttonClearable = await page.find('ods-input >>> ods-button[icon="xmark"]');
+      expect(buttonClearable).not.toBeNull();
     });
   });