add torus rendering #1354
Merged
add torus rendering #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HifiExperiments
added
documentation
ksuprynowicz
approved these changes
Mar 14, 2025
Member
ksuprynowicz
left a comment
ksuprynowicz
left a comment
There was a problem hiding this comment.
Everything looks good :)
ksuprynowicz
added
CR approved
HifiExperiments
added
server
ksuprynowicz
added
QA approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the rendering per #1341, but not the physics, which is a bit more complicated because I think the hull has to be convex (but maybe we can approximate it with multiple, smaller cylinders?)
create is blocked a little by #188, but you can make one from the console/script
curious what people think about the UVs and the scaling behavior. all shapes are meant to fit in their dimensions, so unless the height == 2 * innerRadius, it's scaled a bit weird.