Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum height of tabsPropertiesPage in Create app #1355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Armored-Dragon
Copy link
Member

This just increases the minimum height for the Create app properties page so that it can fit all of the options provided by the "Shape" properties.

image

Fixes #188.
Hopefully benefits #1354.

@Armored-Dragon Armored-Dragon added the enhancement New feature or request label Mar 11, 2025
@Armored-Dragon Armored-Dragon self-assigned this Mar 11, 2025
@Armored-Dragon Armored-Dragon added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Mar 11, 2025
@AleziaKurdis
Copy link
Contributor

Did you test in VR ?
It might cause a perpetual vertical scrollbar to appears, maybe even double in some case like zone of particle.

If it does that, that won't do the job. and we will have to find another solution.
Please test this.

@Armored-Dragon
Copy link
Member Author

Did you test in VR ? It might cause a perpetual vertical scrollbar to appears, maybe even double in some case like zone of particle.

If it does that, that won't do the job. and we will have to find another solution. Please test this.

I have not tested this yet in VR, I was planning on it the next time I get into VR. Thanks for the heads up!

@AleziaKurdis
Copy link
Contributor

Here's an alternate way to fix it:
in
scripts\system\html\css\edit-style.css

you can decrease the font from 15px to 14px here:

image

But that's not the most elegant way to solve it... (if we need more element the problem will happen again.)
If the property wasn't first in the tab, it could be more problematic anyway.

If those "li" were in a container we could add a max-height and let the vertical scrollbar happen within the menu.
But it doesn't seem to be the case and that would make the fix more complicated. And still probably not solving all the possible case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shape window is too short for type dropdown
2 participants