Autostarting lifecycle nodes (fixes #77) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing the autostarting feature for lifecycle nodes in the Nexus system. It allows lifecycle nodes to automatically transition to the active state upon startup.
aaronchongth
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Hi @JRV7903, thanks for the PR. Could you GPG sign and signoff on your commits?
I noticed that the integration tests are failing too, where the nodes do not seem to have transitioned. You can run the tests locally according to instructions here, https://github.com/osrf/nexus/blob/main/.github/workflows/nexus_integration_tests.yaml, to verify if your fix works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the manual
activate_nodefunction frominter_workcell.launch.pyandnexus_calibration.launch.pyand added the new autostart parameter. I have also removed theactivate_node_servicefunction fromworkcell.launch.pyand integrated the autostart parameter for themotion_planner_serverindemo_planner_server.launch.py.