Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1610: Intervals, move over to new schema, finally... #28727

Merged
merged 9 commits into from Apr 30, 2024
Merged

TRT-1610: Intervals, move over to new schema, finally... #28727

merged 9 commits into from Apr 30, 2024

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Apr 19, 2024 •
edited

This PR completes the months long process we've been working towards to smoothly migrate to a new schema for intervals.

  • The non-spyglass intervals chart is attempted to port to structured locators/messages. Could be bugs here but my sample comparison came out looking the same.
  • Flat string locators/messages are removed. tempStructuredLocator and tempStructuredMessage are flipped over to those names, locator and message are now structured.
  • tempSource in json is now promoted to source. I have more plans for the concept and the premise has proven sound.

This will cut the size of intervals files and their charts quite substantially as the bulk of the data was duplicated.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@dgoodwin dgoodwin changed the title drop interval loc msg Intervals, move over to new schema, finally... Apr 19, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@dgoodwin
Copy link
Contributor Author

/retest

@dgoodwin dgoodwin changed the title Intervals, move over to new schema, finally... TRT-1610: Intervals, move over to new schema, finally... Apr 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024 •
edited by openshift-ci bot

@dgoodwin: This pull request references TRT-1610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR completes the months long process we've been working towards to smoothly migrate to a new schema for intervals.

  • The non-spyglass intervals chart is attempted to port to structured locators/messages. Could be bugs here but my sample comparison came out looking the same.
  • Flat string locators/messages are removed. tempStructuredLocator and tempStructuredMessage are flipped over to those names, locator and message are now structured.
  • tempSource in json is now promoted to source. I have more plans for the concept and the premise has proven sound.

This will cut the size of intervals files and their charts quite substantially as the bulk of the data was duplicated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024 •
edited by openshift-ci bot

@dgoodwin: This pull request references TRT-1610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor Author

/retest

@dgoodwin dgoodwin mentioned this pull request Apr 22, 2024
Merged
@dgoodwin
Copy link
Contributor Author

/close

@openshift-ci openshift-ci bot closed this Apr 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@dgoodwin: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot reopened this Apr 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2024 •
edited by openshift-ci bot

@dgoodwin: This pull request references TRT-1610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR completes the months long process we've been working towards to smoothly migrate to a new schema for intervals.

  • The non-spyglass intervals chart is attempted to port to structured locators/messages. Could be bugs here but my sample comparison came out looking the same.
  • Flat string locators/messages are removed. tempStructuredLocator and tempStructuredMessage are flipped over to those names, locator and message are now structured.
  • tempSource in json is now promoted to source. I have more plans for the concept and the premise has proven sound.

This will cut the size of intervals files and their charts quite substantially as the bulk of the data was duplicated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@dgoodwin: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 2c5a072

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-openstack-ovn IncompleteTests
Tests for this run (14) are below the historical average (1870): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-sdn IncompleteTests
Tests for this run (13) are below the historical average (1192): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (13) are below the historical average (919): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (17) are below the historical average (755): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade IncompleteTests
Tests for this run (17) are below the historical average (719): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-builds IncompleteTests
Tests for this run (16) are below the historical average (682): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn IncompleteTests
Tests for this run (16) are below the historical average (1698): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-csi IncompleteTests
Tests for this run (16) are below the historical average (697): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade IncompleteTests
Tests for this run (18) are below the historical average (822): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2590): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (16) are below the historical average (840): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node IncompleteTests
Tests for this run (16) are below the historical average (1926): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-serial IncompleteTests
Tests for this run (16) are below the historical average (870): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-fips IncompleteTests
Tests for this run (16) are below the historical average (1425): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 IncompleteTests
Tests for this run (16) are below the historical average (1933): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-csi IncompleteTests
Tests for this run (16) are below the historical average (815): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd IncompleteTests
Tests for this run (16) are below the historical average (643): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 51e78ac

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (99) are below the historical average (915): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@dgoodwin
Copy link
Contributor Author

/assign @DennisPeriquet

@DennisPeriquet
Copy link
Contributor

/hold
/lgtm

Please cancel hold when ready to merge.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 24, 2024
@dgoodwin
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cab2b73 and 2 for PR HEAD 51e78ac in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 738fd8c and 1 for PR HEAD 51e78ac in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@dgoodwin
Copy link
Contributor Author

Sorry Dennis this needed another lgtm, merge conflict.

@DennisPeriquet
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d015548 and 2 for PR HEAD 09ae5aa in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b04fe1a and 1 for PR HEAD 09ae5aa in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 09ae5aa

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (2) are below the historical average (682): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@dgoodwin
Copy link
Contributor Author

sorry @DennisPeriquet had to push yet another merge conflict for the unrevert of the unnecessary revert. 😢

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: d87fae9

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Medium
[sig-node][invariant] alert/TargetDown should not be at or above info in ns/kube-system
This test has passed 86.84% of 38 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node'] in the last 14 days.

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade d87fae9 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-upgrade d87fae9 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node d87fae9 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade d87fae9 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd d87fae9 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DennisPeriquet
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DennisPeriquet,dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 221cc88 into openshift:master Apr 30, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machine424 machine424 Awaiting requested review from machine424

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@DennisPeriquet DennisPeriquet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dgoodwin @openshift-ci-robot @openshift-trt-bot @DennisPeriquet @openshift-merge-robot