Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remaining sdk client changes for search operations #3522

Merged

Conversation

dhrubo-os
Copy link
Collaborator

Description

[remaining sdk client changes for search operations]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os dhrubo-os force-pushed the multi_tenancy_search_remaining branch from aad510e to 8ef452c Compare February 11, 2025 03:23
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env February 11, 2025 03:24 — with GitHub Actions Inactive
.builder()
.indices(request.indices())
.searchSourceBuilder(request.source())
.tenantId(tenantId)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that opensearch-remote-metadata-sdk will handle null tenantId for non-multi-tenancy case, is that correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@dhrubo-os dhrubo-os merged commit 5432f25 into opensearch-project:main Feb 11, 2025
7 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 11, 2025
Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit 5432f25)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 11, 2025
Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit 5432f25)
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 80.28169% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (d7dec0f) to head (8ef452c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../opensearch/ml/action/handler/MLSearchHandler.java 80.00% 8 Missing and 2 partials ⚠️
...h/ml/action/agents/TransportSearchAgentAction.java 80.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3522      +/-   ##
============================================
+ Coverage     80.25%   80.27%   +0.02%     
- Complexity     6906     6914       +8     
============================================
  Files           610      610              
  Lines         30077    30140      +63     
  Branches       3368     3366       -2     
============================================
+ Hits          24137    24194      +57     
- Misses         4487     4493       +6     
  Partials       1453     1453              
Flag Coverage Δ
ml-commons 80.27% <80.28%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env February 11, 2025 21:22 — with GitHub Actions Inactive
@dbwiddis dbwiddis mentioned this pull request Feb 12, 2025
3 tasks
dhrubo-os added a commit to dhrubo-os/ml-commons that referenced this pull request Feb 12, 2025
Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit 5432f25)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-3522-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5432f25e8a8097332dbfee5eabbfb9fcce5beb6e
# Push it to GitHub
git push --set-upstream origin backport/backport-3522-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-3522-to-2.19.

dhrubo-os added a commit to dhrubo-os/ml-commons that referenced this pull request Feb 12, 2025
Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit 5432f25)
dhrubo-os added a commit that referenced this pull request Feb 12, 2025
Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit 5432f25)
dhrubo-os added a commit that referenced this pull request Feb 13, 2025
Signed-off-by: Dhrubo Saha <[email protected]>
(cherry picked from commit 5432f25)

Co-authored-by: Dhrubo Saha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants