-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remaining sdk client changes for search operations #3522
remaining sdk client changes for search operations #3522
Conversation
Signed-off-by: Dhrubo Saha <[email protected]>
aad510e
to
8ef452c
Compare
.builder() | ||
.indices(request.indices()) | ||
.searchSourceBuilder(request.source()) | ||
.tenantId(tenantId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming that opensearch-remote-metadata-sdk
will handle null tenantId for non-multi-tenancy case, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 5432f25)
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 5432f25)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3522 +/- ##
============================================
+ Coverage 80.25% 80.27% +0.02%
- Complexity 6906 6914 +8
============================================
Files 610 610
Lines 30077 30140 +63
Branches 3368 3366 -2
============================================
+ Hits 24137 24194 +57
- Misses 4487 4493 +6
Partials 1453 1453
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 5432f25)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-3522-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5432f25e8a8097332dbfee5eabbfb9fcce5beb6e
# Push it to GitHub
git push --set-upstream origin backport/backport-3522-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19 Then, create a pull request where the |
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 5432f25)
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 5432f25)
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 5432f25) Co-authored-by: Dhrubo Saha <[email protected]>
Description
[remaining sdk client changes for search operations]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.