Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant Aware Integration Tests #3516

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Feb 8, 2025

Description

Adds integration tests for multitenancy.

The test classes were squashed and cherry-picked from #2818.

Presently the search model and search agent calls are commented out, as MLSearchHandler and TransportSearchAgentAction classes are still using client.search() rather than SDKClient implementations.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env-require-approval February 8, 2025 19:47 — with GitHub Actions Failure
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env-require-approval February 8, 2025 19:47 — with GitHub Actions Failure
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env-require-approval February 10, 2025 02:10 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env-require-approval February 10, 2025 03:27 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env-require-approval February 10, 2025 17:41 — with GitHub Actions Inactive
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (d7dec0f) to head (b5cddd2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3516      +/-   ##
============================================
+ Coverage     80.25%   80.27%   +0.02%     
- Complexity     6906     6909       +3     
============================================
  Files           610      610              
  Lines         30077    30081       +4     
  Branches       3368     3368              
============================================
+ Hits          24137    24147      +10     
+ Misses         4487     4482       -5     
+ Partials       1453     1452       -1     
Flag Coverage Δ
ml-commons 80.27% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant