Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tracing-grpc example #1886

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 17, 2024

Changes

  • Users can simply pass a &str instead of a String
  • Users don't have to create a Vec and pass an array

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6%. Comparing base (3e49f23) to head (cefbcf0).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1886   +/-   ##
=====================================
  Coverage   74.6%   74.6%           
=====================================
  Files        122     122           
  Lines      19952   19952           
=====================================
+ Hits       14901   14902    +1     
+ Misses      5051    5050    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla marked this pull request as ready for review June 17, 2024 21:36
@utpilla utpilla requested a review from a team as a code owner June 17, 2024 21:36
@cijothomas cijothomas merged commit da368d4 into open-telemetry:main Jun 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants