Simplify tracing-grpc example (#1886)

open-telemetry · Jun 17, 2024 · da368d4 · da368d4
1 parent 3e49f23
commit da368d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/examples/tracing-grpc/src/client.rs b/examples/tracing-grpc/src/client.rs
@@ -50,9 +50,9 @@ pub mod hello_world {
 async fn greet() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
  let tracer = global::tracer("example/client");
  let span = tracer
- .span_builder(String::from("Greeter/client"))
+ .span_builder("Greeter/client")
  .with_kind(SpanKind::Client)
- .with_attributes(vec![KeyValue::new("component", "grpc")])
+ .with_attributes([KeyValue::new("component", "grpc")])
  .start(&tracer);
  let cx = Context::current_with_span(span);
  let mut client = GreeterClient::connect("http://[::1]:50051").await?;
@@ -75,10 +75,8 @@ async fn greet() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static
  status_code.to_string()
  }
  };
- cx.span().add_event(
- "Got response!".to_string(),
- vec![KeyValue::new("status", status)],
- );
+ cx.span()
+ .add_event("Got response!", vec![KeyValue::new("status", status)]);
 
  Ok(())
 }

diff --git a/examples/tracing-http-propagator/src/client.rs b/examples/tracing-http-propagator/src/client.rs
@@ -41,7 +41,7 @@ async fn send_request(
  .await?;
 
  cx.span().add_event(
- "Got response!".to_string(),
+ "Got response!",
  vec![KeyValue::new("status", res.status().to_string())],
  );