Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: img is now Image component #257

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: img is now Image component #257

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d0f731
add image aria props
bdougie May 1, 2024
3f0289a
chore: now only neccessary Image props are included
nickytonline May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions components/sections/home-page/GitHubMock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { Heading, Typography } from '../../common/text'
import DecoratedText from '../../common/text/utils/DecoratedText'
import BackgroundStroke from '../../../public/background-strokes/middleRight.svg'


interface GitHubMockProps {
moreHeading: string[]
topFeature: SanityHomePage['topFeature']
Expand Down Expand Up @@ -52,7 +51,7 @@ const GitHubMock: FC<GitHubMockProps> = ({ moreHeading, topFeature }) => {

<p className="text-center font-bold text-textPrimary text-base largeTablet:text-2xl leading-none pb-10 largeTablet:pb-24">
{/* This text needs cololr, grey was hard to read */}
<DecoratedText content={`$orange-to-yellow${moreHeading[1] || ""}`} />
<DecoratedText content={`$orange-to-yellow${moreHeading[1] || ''}`} />
</p>
<p className="text-center font-bold pb-2 tracking-[-0.03em] text-xl largeTablet:text-[2rem] largeTablet:pb-6">
{moreHeading[2] || ''}
Expand All @@ -78,10 +77,12 @@ const GitHubMock: FC<GitHubMockProps> = ({ moreHeading, topFeature }) => {
<Image alt="Doodles" src={BackgroundStroke} />
</div>
<div className="relative largeTablet:left-8 largeTablet:w-4/5 largeTablet:top-8">
<img
src={topFeature?.image as unknown as string}
alt="True impact to the OSS community image"
/>
<Image
src={topFeature?.image as unknown as string}
alt="True impact to the OSS community image"
nickytonline marked this conversation as resolved.
Show resolved Hide resolved
role="img"
aria-label="True impact to the OSS community"
/>
</div>
</div>
</div>
Expand Down
Loading