Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: img is now Image component #257

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: img is now Image component #257

merged 2 commits into from
May 1, 2024

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented May 1, 2024

Description

nick noticed there was an eslint error on #254. I took a look and found the error to unrelated to that PR and fixed it on a new PR.

There is an img that should of been Image and was also missing aria labels.

Related Tickets & Documents

closes #259

Mobile & Desktop Screenshots/Recordings

Steps to QA

Run npm run build locally to see it succeed.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

More errors exist that are Next warnings. I opened an issue for that. #258

[optional] What gif best describes this PR or how it makes you feel?

giphy (22)

Copy link

netlify bot commented May 1, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 3f0289a
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/663237fa89fb6a0008a6cfe0
😎 Deploy Preview https://deploy-preview-257--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie bdougie marked this pull request as ready for review May 1, 2024 05:47
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

components/sections/home-page/GitHubMock.tsx Show resolved Hide resolved
@nickytonline nickytonline force-pushed the linter-fix branch 2 times, most recently from c7ebe1d to 6af3ec0 Compare May 1, 2024 12:37
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗

@nickytonline nickytonline changed the title add image aria props fix: add image aria props May 1, 2024
@nickytonline nickytonline changed the title fix: add image aria props fix: img is now Image component May 1, 2024
@nickytonline nickytonline merged commit 2cf60b4 into main May 1, 2024
6 checks passed
@nickytonline nickytonline deleted the linter-fix branch May 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img tag needs aria labels
3 participants