-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: img is now Image component #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
nickytonline
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nickytonline
approved these changes
May 1, 2024
nickytonline
force-pushed
the
linter-fix
branch
2 times, most recently
from
May 1, 2024 12:37
c7ebe1d
to
6af3ec0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔗
brandonroberts
approved these changes
May 1, 2024
nickytonline
changed the title
fix: add image aria props
fix: img is now Image component
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nick noticed there was an eslint error on #254. I took a look and found the error to unrelated to that PR and fixed it on a new PR.
There is an
img
that should of beenImage
and was also missing aria labels.Related Tickets & Documents
closes #259
Mobile & Desktop Screenshots/Recordings
Steps to QA
Run
npm run build
locally to see it succeed.Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
More errors exist that are Next warnings. I opened an issue for that. #258
[optional] What gif best describes this PR or how it makes you feel?