New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pt-br translation #35
base: main
Are you sure you want to change the base?
Conversation
β Deploy Preview for sauced-intro ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@CBID2 take a look at this. |
Okay @antonio-pedro99, so should I close my PR? |
Also, hereβs how to put someone elseβs commit to your branch: https://tighten.com/insights/adding-commits-to-a-pull-request/ |
Thanks for that. It seems that you did not checked |
Let's work with one. |
Turns out you had editing permission on my PR @antonio-pedro99 |
Sorry for that. Any way, you can add commits here if you see some nits |
Hey @antonio-pedro99. I forked your repo but I do not have permission to add my commits. Can you grant me permission please? |
Sure, I see you are getting the same issue. |
It worked @antonio-pedro99. By the way, I just did the translation for the "Como Contribuir Para Open Source". Now, they did not have Angolan Portuguese in Google Translate so feel free to make it necessary to suit your dialect. :) |
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR. |
Okay |
What files are empty again @antonio-pedro99? |
@CBID2 One more thing, I was checking some[1] repos that support translations, many of them do not translate the file names, so I renamed the file back to English. [1] CNCF Glossary |
Some of them were empty, I deleted them. I will add them as long as I am translating them. |
Interesting π€ |
@antonio-pedro99, is this the reference? |
Not quite, this would be the reference. |
Is this ready to review now @antonio-pedro99? |
No, it's not! |
Hey, @antonio-pedro99! :) How are you? :) I made some additions to your pull request:
I think all you need to do now is put the sidebar and navbar files into the |
Hi Chriss |
Signed-off-by: Antonio Pedro <[email protected]>
Good idea @antonio-pedro99. I'll ask in a couple of communities too. |
I appreciate that, @antonio-pedro99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'll stop at file 3. Perhaps someone else or me, later, can continue.
This review is mainly about language syntax and grammar, not diving deep into the actual translation. Hope it helps
|
||
Bem-vindo ao curso "Getting Started with Open Source"! | ||
Este curso abrangente irΓ‘ guiΓ‘-lo pelo fascinante mundo do open source e ajudΓ‘-lo a se tornar um colaborador ativo. | ||
Ao final deste curso, vocΓͺ deve ter uma compreensΓ£o sΓ³lida de como encontrar, participar e contribuir para projetos de open source, bem como desenvolver o seu currΓculo de open source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I guess I'm missing context but "currΓculo de open source" doesn't make sense for me. Not even in the original.
So as to not deviate from the original I'd not change here. IMO it should be "currΓculo de contribuiçáes open source" or sometinh. But then it should come first from the source material I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vasfvitor! :) This part of the introduction talks about the purpose of the course. In reading it in English, I do agree that the wording could be a bit better.
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this was a long one. Overall there are some suggestions that I think that's needs to be analyzed before accepting. I'm refering to the git terms, Ideally or we translate every term or we don't translated none. This is so the content is easier to follow.
I'd say we use original git terms because the CLI is not translated and it would be easier to relate "push" to git push
instead of "empurar" to it. Aften this decision has been made, then changes should be made throughout each translated page. Even if I suggested different in the review.
This is all about having a consistent translation. Thank you and I'd love to hear yall thoughts on this.
|
||
## PrΓ©-requisitos | ||
|
||
Antes de completar o seguinte passo a passo, complete o seguinte: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Antes de completar o seguinte passo a passo, complete o seguinte:
I'd say to avoid repetition "completar" and "complete" but the source material it's no different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you that we should use the original git terms for the reasons you said.
cd projects/practice-repository | ||
``` | ||
|
||
Agora que vocΓͺ estΓ‘ no diretΓ³rio correto, use os seguintes comandos para adicionar as alteraçáes que vocΓͺ fez e escrever uma mensagem de confirmação com uma descrição das alteraçáes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, same "commit" situation, now is "confirmar", thankfully it follows a previous translation :D
git push origin main | ||
``` | ||
|
||
O commando `push origen main` empurra as suas alteraçáes para o ramo "main" do seu repositΓ³rio remoto. Se vocΓͺ quiser verificar o seu trabalho, navegue atΓ© o seu repositΓ³rio do GitHub. VocΓͺ deve ver 'hello world!' no seu arquivo README.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O commando `push origen main` empurra as suas alteraçáes para o ramo "main" do seu repositΓ³rio remoto. Se vocΓͺ quiser verificar o seu trabalho, navegue atΓ© o seu repositΓ³rio do GitHub. VocΓͺ deve ver 'hello world!' no seu arquivo README.md. | |
O commando `push origen main` empurra as suas alteraçáes para o ramo "main" do seu repositΓ³rio remoto. Se vocΓͺ quiser verificar o seu trabalho, navegue atΓ© o seu repositΓ³rio do GitHub. VocΓͺ deve ver 'hello world!' no seu arquivo README.md. |
Here "branch" is translated as "ramo" but a few lines above it's not.
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Hey @antonio-pedro99. You have some merge conflicts here. |
Description
This is a continuation of #34, adding a Portuguese translation(and fixing the French translation) of the course. Doing so makes the course accessible to Portuguese-speaking developers who want to contribute to open source projects.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #16
Closes #56
Mobile & Desktop Screenshots/Recordings
The first translation
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?