Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pt-br translation #35

Draft
wants to merge 82 commits into
base: main
Choose a base branch
from

Conversation

antonio-pedro99
Copy link
Contributor

@antonio-pedro99 antonio-pedro99 commented Aug 13, 2023

Description

This is a continuation of #34, adding a Portuguese translation(and fixing the French translation) of the course. Doing so makes the course accessible to Portuguese-speaking developers who want to contribute to open source projects.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #16
Closes #56

Mobile & Desktop Screenshots/Recordings

image

The first translation
image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 13, 2023

βœ… Deploy Preview for sauced-intro ready!

Name Link
πŸ”¨ Latest commit 701d84c
πŸ” Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/65f19594468e9600080b7a85
😎 Deploy Preview https://deploy-preview-35--sauced-intro.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antonio-pedro99
Copy link
Contributor Author

@CBID2 take a look at this.
I am going incremental, not adding empty files to the PR.

@antonio-pedro99 antonio-pedro99 marked this pull request as draft August 13, 2023 10:24
@CBID2
Copy link
Contributor

CBID2 commented Aug 13, 2023

Okay @antonio-pedro99, so should I close my PR?

@CBID2
Copy link
Contributor

CBID2 commented Aug 13, 2023

@CBID2 take a look at this.
I am going incremental, not adding empty files to the PR.

Also, here’s how to put someone else’s commit to your branch: https://tighten.com/insights/adding-commits-to-a-pull-request/

@antonio-pedro99
Copy link
Contributor Author

@CBID2 take a look at this.
I am going incremental, not adding empty files to the PR.

Also, here’s how to put someone else’s commit to your branch: https://tighten.com/insights/adding-commits-to-a-pull-request/

Thanks for that. It seems that you did not checked allow edit from mantainers hahah. I was trying this, but getting permission errors.

@antonio-pedro99
Copy link
Contributor Author

Okay @antonio-pedro99, so should I close my PR?

Let's work with one.

@CBID2
Copy link
Contributor

CBID2 commented Aug 13, 2023

Okay @antonio-pedro99, so should I close my PR?

Let's work with one.

Turns out you had editing permission on my PR @antonio-pedro99
04F16EBB-E99F-43E8-9066-C556365693BD

@antonio-pedro99
Copy link
Contributor Author

Okay @antonio-pedro99, so should I close my PR?

Let's work with one.

Turns out you had editing permission on my PR @antonio-pedro99 04F16EBB-E99F-43E8-9066-C556365693BD

Sorry for that. Any way, you can add commits here if you see some nits

@CBID2
Copy link
Contributor

CBID2 commented Aug 14, 2023

Okay @antonio-pedro99, so should I close my PR?

Let's work with one.

Turns out you had editing permission on my PR @antonio-pedro99 04F16EBB-E99F-43E8-9066-C556365693BD

Sorry for that. Any way, you can add commits here if you see some nits

Hey @antonio-pedro99. I forked your repo but I do not have permission to add my commits. Can you grant me permission please?

@antonio-pedro99
Copy link
Contributor Author

Sure, I see you are getting the same issue.
Let me see what I can do.

@CBID2
Copy link
Contributor

CBID2 commented Aug 14, 2023

Sure, I see you are getting the same issue. Let me see what I can do.

It worked @antonio-pedro99. By the way, I just did the translation for the "Como Contribuir Para Open Source". Now, they did not have Angolan Portuguese in Google Translate so feel free to make it necessary to suit your dialect. :)

@antonio-pedro99
Copy link
Contributor Author

Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.

@CBID2
Copy link
Contributor

CBID2 commented Sep 2, 2023

Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.

Okay

@CBID2
Copy link
Contributor

CBID2 commented Sep 2, 2023

Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.

What files are empty again @antonio-pedro99?

@antonio-pedro99
Copy link
Contributor Author

@CBID2 One more thing, I was checking some[1] repos that support translations, many of them do not translate the file names, so I renamed the file back to English.

[1] CNCF Glossary

@antonio-pedro99
Copy link
Contributor Author

Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.

What files are empty again @antonio-pedro99?

Some of them were empty, I deleted them. I will add them as long as I am translating them.

@CBID2
Copy link
Contributor

CBID2 commented Sep 2, 2023

@CBID2 One more thing, I was checking some[1] repos that support translations, many of them do not translate the file names, so I renamed the file back to English.

[1] CNCF Glossary

Interesting πŸ€”

@CBID2
Copy link
Contributor

CBID2 commented Sep 2, 2023

Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.

What files are empty again @antonio-pedro99?

Some of them were empty, I deleted them. I will add them as long as I am translating them.

@antonio-pedro99, is this the reference?

@antonio-pedro99
Copy link
Contributor Author

Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.

What files are empty again @antonio-pedro99?

Some of them were empty, I deleted them. I will add them as long as I am translating them.

@antonio-pedro99, is this the reference?

Not quite, this would be the reference.
BTW, I think adding this file is good idea to invite more people to add other idioms support.

@CBID2
Copy link
Contributor

CBID2 commented Sep 9, 2023

Is this ready to review now @antonio-pedro99?

@antonio-pedro99
Copy link
Contributor Author

Is this ready to review now @antonio-pedro99?

No, it's not!
I will make it ready when it is fine.

@CBID2
Copy link
Contributor

CBID2 commented Sep 19, 2023

Hey, @antonio-pedro99! :) How are you? :) I made some additions to your pull request:

  1. translating the file names into Portuguese
  2. Adding a Portuguese version of the sidebar
  3. Revise hyperlink of the course directions
  4. Add a Brazilian flag emoji to the sidebar

I think all you need to do now is put the sidebar and navbar files into the translation/pt-br folder as I did with Geoffrey in the French version. That's how we got it to work.

@antonio-pedro99
Copy link
Contributor Author

Hey, @antonio-pedro99! :) How are you? :) I made some additions to your pull request:

  1. translating the file names into Portuguese
  2. Adding a Portuguese version of the sidebar
  3. Revise hyperlink of the course directions
  4. Add a Brazilian flag emoji to the sidebar

I think all you need to do now is put the sidebar and navbar files into the translation/pt-br folder as I did with Geoffrey in the French version. That's how we got it to work.

Hi Chriss
Thanks for letting me know
I will take a look during the week ou next week. I been kind busy here.

Signed-off-by: Antonio Pedro <[email protected]>
@CBID2
Copy link
Contributor

CBID2 commented Jan 6, 2024

@CBID2 left some comments.

The Portuguese translation is good, but I think it should be good to get reviews from another Portuguese speakers.

I will ask some folks from my community.

Good idea @antonio-pedro99. I'll ask in a couple of communities too.

@BekahHW
Copy link
Member

BekahHW commented Jan 9, 2024

@CBID2 left some comments.

The Portuguese translation is good, but I think it should be good to get reviews from another Portuguese speakers. I will ask some folks from my community.

I appreciate that, @antonio-pedro99

Copy link

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I'll stop at file 3. Perhaps someone else or me, later, can continue.

This review is mainly about language syntax and grammar, not diving deep into the actual translation. Hope it helps


Bem-vindo ao curso "Getting Started with Open Source"!
Este curso abrangente irΓ‘ guiΓ‘-lo pelo fascinante mundo do open source e ajudΓ‘-lo a se tornar um colaborador ativo.
Ao final deste curso, vocΓͺ deve ter uma compreensΓ£o sΓ³lida de como encontrar, participar e contribuir para projetos de open source, bem como desenvolver o seu currΓ­culo de open source.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I guess I'm missing context but "currΓ­culo de open source" doesn't make sense for me. Not even in the original.

So as to not deviate from the original I'd not change here. IMO it should be "currículo de contribuiçáes open source" or sometinh. But then it should come first from the source material I guess

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vasfvitor! :) This part of the introduction talks about the purpose of the course. In reading it in English, I do agree that the wording could be a bit better.

translations/pt-br/01-introdução.md Outdated Show resolved Hide resolved
translations/pt-br/01-introdução.md Outdated Show resolved Hide resolved
translations/pt-br/02-o-que-Γ©-open-source.md Outdated Show resolved Hide resolved
translations/pt-br/02-o-que-Γ©-open-source.md Outdated Show resolved Hide resolved
translations/pt-br/02-o-que-Γ©-open-source.md Outdated Show resolved Hide resolved
translations/pt-br/03-por-que-open-source.md Outdated Show resolved Hide resolved
translations/pt-br/03-por-que-open-source.md Outdated Show resolved Hide resolved
translations/pt-br/03-por-que-open-source.md Outdated Show resolved Hide resolved
translations/pt-br/03-por-que-open-source.md Outdated Show resolved Hide resolved
CBID2 and others added 9 commits January 10, 2024 22:24
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Co-authored-by: Vitor Ayres <[email protected]>
Copy link

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this was a long one. Overall there are some suggestions that I think that's needs to be analyzed before accepting. I'm refering to the git terms, Ideally or we translate every term or we don't translated none. This is so the content is easier to follow.

I'd say we use original git terms because the CLI is not translated and it would be easier to relate "push" to git push instead of "empurar" to it. Aften this decision has been made, then changes should be made throughout each translated page. Even if I suggested different in the review.

This is all about having a consistent translation. Thank you and I'd love to hear yall thoughts on this.


## PrΓ©-requisitos

Antes de completar o seguinte passo a passo, complete o seguinte:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antes de completar o seguinte passo a passo, complete o seguinte:

I'd say to avoid repetition "completar" and "complete" but the source material it's no different.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that we should use the original git terms for the reasons you said.

translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
cd projects/practice-repository
```

Agora que vocΓͺ estΓ‘ no diretΓ³rio correto, use os seguintes comandos para adicionar as alteraçáes que vocΓͺ fez e escrever uma mensagem de confirmação com uma descrição das alteraçáes:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, same "commit" situation, now is "confirmar", thankfully it follows a previous translation :D

git push origin main
```

O commando `push origen main` empurra as suas alteraçáes para o ramo "main" do seu repositΓ³rio remoto. Se vocΓͺ quiser verificar o seu trabalho, navegue atΓ© o seu repositΓ³rio do GitHub. VocΓͺ deve ver 'hello world!' no seu arquivo README.md.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O commando `push origen main` empurra as suas alteraçáes para o ramo "main" do seu repositΓ³rio remoto. Se vocΓͺ quiser verificar o seu trabalho, navegue atΓ© o seu repositΓ³rio do GitHub. VocΓͺ deve ver 'hello world!' no seu arquivo README.md.
O commando `push origen main` empurra as suas alteraçáes para o ramo "main" do seu repositΓ³rio remoto. Se vocΓͺ quiser verificar o seu trabalho, navegue atΓ© o seu repositΓ³rio do GitHub. VocΓͺ deve ver 'hello world!' no seu arquivo README.md.

Here "branch" is translated as "ramo" but a few lines above it's not.

translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
translations/pt-br/04-ferramentas-utilizadas.md Outdated Show resolved Hide resolved
@BekahHW BekahHW marked this pull request as draft January 17, 2024 18:38
@CBID2
Copy link
Contributor

CBID2 commented Mar 30, 2024

Hey @antonio-pedro99. You have some merge conflicts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Improve the style on the README documentation Feature: Translate the course to other language
7 participants