Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add Spanish (es) translations #115

Draft
wants to merge 84 commits into
base: main
Choose a base branch
from

Conversation

samucodesh
Copy link
Contributor

@samucodesh samucodesh commented Feb 9, 2024

Description

This PR adds a Spanish translation for the course. This will help Spanish and Latin Americans
contributors start their journey towards open source.

What type of PR is this? (check all applicable)

  • [x ] πŸ• Feature
  • πŸ› Bug Fix
  • [ x] πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #116

Mobile & Desktop Screenshots/Recordings

README

eslanguagesupport

navbar

spanishnavbar

spanishennavbar

sidebar

spanishsidebar

Steps to QA

Added to documentation?

  • [x ] πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 9, 2024

βœ… Deploy Preview for sauced-intro ready!

Name Link
πŸ”¨ Latest commit b84d1f5
πŸ” Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/664a85269673660008b25629
😎 Deploy Preview https://deploy-preview-115--sauced-intro.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2
Copy link
Contributor

CBID2 commented Feb 9, 2024

Hi @samucodesh! :) Thanks for your translation! :) Can you link the corresponding issue in the Related Documents & Tickets section of your PR form?

@CBID2 CBID2 requested a review from BekahHW February 9, 2024 23:44
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samucodesh! :) The only piece of feedback is that we want to keep the word "open source" in English so turn cΓ³digo abierto back into English please.

@samucodesh
Copy link
Contributor Author

It took me several weeks to update my branch, I look forward to your feedback

@adiati98
Copy link
Member

Hey @samucodesh,

Thank you so much for the PR and for your initiative to update this branch with our latest changes! We truly appreciate it! ✨

We're sorry that our @open-sauced/docs team still have no time and resources to review your PR.

Also, heads up, we will have more (big) updates to come in the next few months. So, we're wondering if you're interested in hosting and maintaining this Spanish translation yourself in your forked repo as one of our community translations.

The benefit of doing so are:

  • you will have the opportunity to learn to maintain a project and become the maintainer of the Spanish translation as it will live in your forked repo,
  • you can make the Spanish translation available soonest,
  • you can update the translation faster as you are able to review and merge in PRs yourself as a maintainer.

Please let us know what do you think and we can discuss further from there.

Thank you! 😊

@samucodesh
Copy link
Contributor Author

Absolutely! I completely understand about the @open-sauced/docs team's workload. I'd be thrilled to host and maintain the Spanish translation in my forked repo as a community translation. This would be a fantastic learning experience for me, and I'm confident I can get the Spanish version out quickly. I'm also happy to handle future updates as they come. Thank you so much for the opportunity!

@adiati98
Copy link
Member

Absolutely! I completely understand about the @open-sauced/docs team's workload. I'd be thrilled to host and maintain the Spanish translation in my forked repo as a community translation. This would be a fantastic learning experience for me, and I'm confident I can get the Spanish version out quickly. I'm also happy to handle future updates as they come. Thank you so much for the opportunity!

Thank you so much for your interest! ✨

This will be the pilot of our community translations and I'm as much as excited as you! πŸ₯³

That said, you can start with getting ready to maintain and host the Spanish translation on your forked repository. πŸ™ŒπŸ½

Please be noted, this is also new for me, so I still try to find the best way to do this. But I'll do my best to support you whenever I can!
I'll document the process so we can help other translations. So, please keep me in the loop with the process in this discussion! 😊

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@adiati98 adiati98 marked this pull request as draft May 19, 2024 23:04
@adiati98
Copy link
Member

Hey @samucodesh,

Heads up. I'm coverting this PR as draft as we're discussing on moving this as community translations. Thanks! πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add Spanish (es) translations
5 participants