Master mysterious egg loco 1 #4489
Draft
+656
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
2 times, most recently
from
5906a60 to
1540589
Compare
loco-odoo
commented
Apr 28, 2025
| this.dialogService = this.services.dialog; | ||
| const editableEls = findOEditable(this.editable); | ||
| this.elToTranslationInfoMap = new Map(); | ||
| const translatedAttrs = ["placeholder", "title", "alt", "value"]; |
There was a problem hiding this comment.
Note: for the moment, there is a problem when a form field has an input attribute. I will solve it in another PR; the problem is that interactions that should not be started in edit mode are somehow started and destroyed when entering translate mode.
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
1540589 to
4674893
Compare
loco-odoo
commented
Apr 29, 2025
| @@ -0,0 +1,72 @@ | |||
| import { Dialog } from "@web/core/dialog/dialog"; | |||
There was a problem hiding this comment.
Just copy pasted from website
|
To fix in stable:
|
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
4674893 to
bdc5c86
Compare
loco-odoo
commented
Apr 29, 2025
| @@ -37,9 +49,6 @@ export class SetupEditorPlugin extends Plugin { | |||
| el.setAttribute("data-editor-message", _t("DRAG BUILDING BLOCKS HERE")); | |||
| } | |||
| }); | |||
|
|
|||
| // Set the `contenteditable` attribute on the editables. | |||
| this.setContenteditable(); | |||
There was a problem hiding this comment.
Done at the normalize so useless at the end of the setup
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
e24556e to
897f4ab
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
bdc5c86 to
7f8e782
Compare
- translate attributes - translate selections - add a message when trying to translate not editable elements - add a message to explain the translation colors
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
7f8e782 to
27f8f1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.