Skip to content

s_donation_button options #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 94 commits into from
Closed

s_donation_button options #4240

wants to merge 94 commits into from

Conversation

@agau-odoo
Copy link

@agau-odoo agau-odoo commented Mar 21, 2025 •
edited
Loading

upgrade PR https://github.com/odoo/upgrade/pull/7539

needs #4489 for translation

@robodoo
Copy link

robodoo commented Mar 21, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch from f468b7f to 80b3d5d Compare March 27, 2025 12:21
@ged-odoo ged-odoo force-pushed the master-mysterious-egg branch from 27a1402 to 8c6b756 Compare March 27, 2025 20:00
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch 4 times, most recently from de09195 to 030f5d2 Compare March 31, 2025 09:02
@agau-odoo agau-odoo marked this pull request as ready for review March 31, 2025 09:02
@robodoo
Copy link

robodoo commented Mar 31, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch from 030f5d2 to e79686c Compare March 31, 2025 12:08
@agau-odoo agau-odoo changed the title wip: add BuilderList add BuilderList Apr 3, 2025
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch from e79686c to 27f2247 Compare April 3, 2025 08:48
FrancoisGe
FrancoisGe reviewed Apr 3, 2025
View reviewed changes
addons/html_builder/static/src/core/building_blocks/builder_list.js Outdated
Comment on lines 61 to 69
Copy link

@FrancoisGe FrancoisGe Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use Component validation props ?

Copy link

@FrancoisGe FrancoisGe Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Maybe checkc ommunity/addons/html_editor/static/src/main/toolbar/toolbar.js)

Copy link
Author

@agau-odoo agau-odoo Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I actually forgot to look into it. 😅 I fixed it in a 4th commit
Do you know if it's possible to validate a prop against other props?

Copy link

@FrancoisGe FrancoisGe Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agau-odoo No idea. Maybe ask to @ged-odoo

Copy link

@ged-odoo ged-odoo Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. you can define a custom validate function, but it only takes the prop value, not other props

@divy-odoo divy-odoo force-pushed the master-mysterious-egg branch from 4648461 to 2d7aa09 Compare April 8, 2025 12:19
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch from c3a59b5 to caa8ba4 Compare April 10, 2025 08:35
@agau-odoo agau-odoo marked this pull request as draft April 10, 2025 09:26
@robodoo
Copy link

robodoo commented Apr 10, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@agau-odoo agau-odoo mentioned this pull request Apr 10, 2025
Closed
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch 2 times, most recently from 109efe4 to 31a3a1c Compare April 17, 2025 09:57
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch 2 times, most recently from a0532c2 to 850f0e8 Compare April 18, 2025 10:12
@agau-odoo agau-odoo marked this pull request as ready for review April 18, 2025 12:34
@robodoo
Copy link

robodoo commented Apr 18, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch from 850f0e8 to 90387e4 Compare April 18, 2025 12:44
@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch from 87924d0 to 60ad945 Compare April 18, 2025 13:24
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch 3 times, most recently from 4231463 to 0e0de55 Compare April 24, 2025 11:39
FrancoisGe
FrancoisGe reviewed Apr 25, 2025
View reviewed changes
addons/html_builder/static/src/website_payment/donation_option.xml Outdated
Copy link

@FrancoisGe FrancoisGe Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why class="" ?

Copy link
Author

@agau-odoo agau-odoo Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied website_payment.donation.prefilledButtons, should I clean it up?

addons/website_payment/static/src/snippets/s_donation/options.xml Outdated
Comment on lines 20 to 23
Copy link

@FrancoisGe FrancoisGe Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to move "o_not_editable" and contenteditable="false" ?

Copy link
Author

@agau-odoo agau-odoo Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to allow translating the description. Previously, this was done by hiding the button and showing normally hidden fields, which are deleted in this PR.
Without this modification, the descriptions can't be translated anymore (regression).

addons/website_payment/views/snippets/s_donation.xml Outdated
Comment on lines 18 to 22
Copy link

@FrancoisGe FrancoisGe Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question

@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch 2 times, most recently from c333b15 to 6678924 Compare May 8, 2025 10:04
@agau-odoo agau-odoo force-pushed the master-mysterious-egg-agau-4 branch from 6678924 to d43a1b6 Compare May 8, 2025 10:06
@agau-odoo agau-odoo marked this pull request as draft May 8, 2025 11:26
@robodoo
Copy link

robodoo commented May 8, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@agau-odoo agau-odoo changed the title add BuilderList s_donation_button options May 8, 2025
@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch from 5b240d1 to 558b8e7 Compare May 20, 2025 05:41
@ged-odoo ged-odoo force-pushed the master-mysterious-egg branch 5 times, most recently from edff5d7 to d31ecfa Compare May 21, 2025 13:57
@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch 3 times, most recently from 314790f to 48edd7d Compare May 22, 2025 06:44
@ged-odoo ged-odoo force-pushed the master-mysterious-egg branch from 48edd7d to 54b7266 Compare May 22, 2025 08:18
@fw-bot fw-bot deleted the branch master-mysterious-egg May 29, 2025 16:38
@fw-bot fw-bot closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ged-odoo ged-odoo ged-odoo left review comments

@FrancoisGe FrancoisGe FrancoisGe left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.