Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the picos package into several smaller packages, roughly:
picos
-> (backoff
,thread-local-storage
)picos_aux
-> (backoff
,multicore-magic
)picos_std
->picos
(,backoff
,multicore-magic
)picos_stdio
->picos_std
,picos_aux
, andunix
(,mtime
,psq
)picos_stdio_cohttp
->picos_stdio
(,cohttp
,fmt
,uri
)picos_mux
->picos_std
,picos_aux
, and optionally onpicos_stdio
picos_lwt
->picos_std
,picos_aux
(,lwt
)picos_meta
-> all of the aboveThe above changes should make it easier for people to depend only on the packages they need. A single package with dependencies to
lwt
andcohttp
is just too heavy.This also removes the
Exn_bt
module and type entirely. It is impossible to have such a module in OCaml.Due to the split to multiple packages the structure of the documentation has also been updated. Currently odoc doesn't support references between packages, which, unfortunately, downgrades the quality of the documentation.
Finally, it has become clear that Miou is not compatible with Picos. There are several reasons for this:
Cancel_after
, because it is, according to Miou's author, impossible to support in MirageOSFiber.t
(replacing it with an integer id)Fiber.FLS
unacceptable, because it uses theObj
module to store heterogenous values in an array (similar to whatStdlib.Domain.DLS
does)Fiber.current
andFiber.spawn
(note that TLS also usesObj
likeStdlib.Domain.DLS
)Exn_bt
module(, library, and package) — those have been removedThanks to c-cube for starting the work on this in #249!