Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting Picos into (at least) two packages #87

Closed
polytypic opened this issue Apr 9, 2024 · 3 comments · Fixed by #255
Closed

Consider splitting Picos into (at least) two packages #87

polytypic opened this issue Apr 9, 2024 · 3 comments · Fixed by #255

Comments

@polytypic
Copy link
Collaborator

For example,

  • a core picos package would include picos and maybe picos.sync and more strongly maybe picos.stdio.
  • an additional picos_samples package would contain other things (e.g. sample schedulers) not strictly needed by the core package.
@polytypic polytypic modified the milestone: 0.2.0 Apr 9, 2024
@polytypic polytypic changed the title Split Picos into (at least) two packages Consider splitting Picos into (at least) two packages Apr 16, 2024
@polytypic
Copy link
Collaborator Author

polytypic commented May 4, 2024

Thinking about this later, I started thinking about packaging things the opposite/different way:

  • a picos_core package with just the core Picos framework (i.e. which is currently the picos library inside the picos package), and
  • a picos package that includes both the core and everything else in this repository.

@polytypic polytypic linked a pull request Sep 2, 2024 that will close this issue
@zoj613
Copy link

zoj613 commented Sep 15, 2024

I'm getting a library picos_mux not found error when including picos_mux in libraries list inside a dune file. picos_mux has been installed and picos_io gets included just fine. Is there something i'm missing here?

@polytypic
Copy link
Collaborator Author

The picos_mux package contains multiple libraries picos_mux.fifo, picos_mux.multififo, and picos_mux.random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants