Add a braille setting for Chinese word segmentation - #20642
Draft
cary-rowen wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
HI cc @keyang556 |
Contributor
|
OK, I'll test it. |
Contributor
|
Fixed, thank you. |
Contributor
Author
|
Thanks @keyang556 |
Contributor
|
I don't know, if possible, off by default in zhtw table(or nvda language), but on by default in zhcn table? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #20471
Summary of the issue:
Chinese word segmentation is always used with Chinese braille output tables.
Some users need to disable this behavior and let the selected braille table translate the original text directly.
Description of user facing changes:
A "Use Chinese word segmentation" checkbox has been added to the Braille settings category.
It is enabled by default to preserve the existing behavior and only affects Chinese braille output tables.
Context-sensitive help and User Guide documentation are included.
Description of developer facing changes:
There are no public API changes.
Description of development approach:
The change follows the conventions of existing Braille settings and preserves the current behavior by default.
Testing strategy:
Manual testing should cover the following:
F1on the setting and confirm that the corresponding User Guide section opens.Known issues with pull request:
None known.
Code Review Checklist: