Skip to content

Add pull request templates - #51

Open
makhlwf wants to merge 4 commits into
nvaccess:masterfrom
makhlwf:pr-templates
Open

Add pull request templates#51
makhlwf wants to merge 4 commits into
nvaccess:masterfrom
makhlwf:pr-templates

Conversation

@makhlwf

@makhlwf makhlwf commented Aug 8, 2026

Copy link
Copy Markdown

This adds default PR templates for the add-on template repository, covering part of #48.

Comment thread .github/PULL_REQUEST_TEMPLATE/code_change.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE/translation.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,33 @@
<!---

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will probably be easier for most repos and contributors to just use a single template, like we do in NVDA.
I think we do need two different PR templates though, one designed for contributions to this template, and one designed for contributions to add-ons.
when syncing via #46 , we should set the default template appropriately.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest commits, I reworked the templates, so now we have only two: one for changes to the template itself and the other for the add-ons. I put them in the pull requests directory in the .github folder, so when someone makes a pull request, they will show up together. It's easy for me, after the mentioned pull requests are merged, to make the script delete the template-specific pull request template, then move the add-on up a directory and rename it.

@seanbudd
seanbudd marked this pull request as draft August 10, 2026 01:59
@makhlwf
makhlwf marked this pull request as ready for review August 12, 2026 00:37
@makhlwf

makhlwf commented Aug 12, 2026

Copy link
Copy Markdown
Author

i think this will address all consernes

@makhlwf
makhlwf requested a review from seanbudd August 12, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants