-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including LGBM parameters to lgbm_classification_learner #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-behar
requested review from
fabiofabris,
GiulioCMSanto and
eduardodx
September 2, 2022 22:49
nicolas-behar
added
review-request
Waiting to be reviewed
and removed
wip
Work in progress
labels
Sep 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 94.69% 94.33% -0.36%
==========================================
Files 25 34 +9
Lines 1507 2120 +613
Branches 203 280 +77
==========================================
+ Hits 1427 2000 +573
- Misses 48 83 +35
- Partials 32 37 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eduardodx
requested changes
Sep 14, 2022
fabiofabris
approved these changes
Oct 19, 2022
eduardodx
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
IN DEVELOPMENT
Todo list
Background context
Some of the already implemented LGBM parameters can't be used by the lgbm_classification_learner function.
Description of the changes proposed in the pull request
We are including these parameters by changing the lgbm.train call function with these parameters, that can be passed by the user if needed.
Related PRs
#197