Spring clean-up

[Nirmal4G]

These are the issues that are fixed in this PR

• Closes Error in VSTS - The "Message" parameter is not supported by the "Error" task. #26
• Closes WPF: Adding xmlns with clr-namespace to XAML breaks build with cryptic error message #32
• Closes 'The target "Build" does not exist in the project' for PCL profiles 2 and 328 #35
• Closes Update samples to the VS 2017 15.6 way of things.  #53
• Closes dotnet sdk import issues #64
• Closes Build failing when including WPF items #66
• Closes Using MSBuild Sdk extras for UWP apps #67

[clairernovotny]

One thing to be aware of -- we shouldn't be explicitly referencing these type-forwarder façades. That causes issues since they're added as framework references which then cannot be found in the GAC. We should only be referencing implementation assemblies.

[Nirmal4G]

I have checked with my projects, no problem there. Besides they are the same references that I added from the original Xamarin project templates.

[Nirmal4G]

There is some problem with the build. I tried to fix it but no luck. I don't know about TFS much!

TF400813: The user 'a1ba01a6-482e-41c7-88e2-142b33cf8b63' is not authorized to access this resource.

[clairernovotny]

The build should be fixed with the latest code in master if you update to that.

[Nirmal4G]

Thanks.

I have seen from some PRs that others can directly commit into the said PR. It would be simple for you and others to directly change things, right?
How can I enable them for this PR, Is there any option in the fork's repo settings?

[clairernovotny]

The docs to configure that are here:
https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

[Nirmal4G]

Almost done. Don't have time for ASP/WCF/WFF. Will do in a separate PR.

For the public properties in the old package, I'll add a rename shim in the main props/targets file. I want to keep the file/filename structure as it is. Since, it'll be easy for me to provide future PRs

You can merge anytime.

[clairernovotny]

It's going to take me some time to review this because there are a lot of changes. In the future, I'd appreciate more, smaller, PR's with discreet changes.

Second, I do not intend on accepting a dependency on another package here. Please consolidate into this PR if needed.

Thanks

[clairernovotny]

Update...looking further, I really can't compare these since there is too much renaming. Can you please submit a series of smaller targeted changes? I don't mind having a dozen PR's that are reviewable. As it is now, I can't see what's different, in large part due to the renaming.

I also cannot fully remove support for PackageRef yet since some of the designers (and VSfM) still don't fully support the Sdk syntax yet.

I do appreciate all of the updates, but this chunk is too big to digest. Sorry.
Oren

[Nirmal4G]

In the future, I'd appreciate more, smaller, PR's with discreet changes.

I want to but I continuously update them with using my projects, also the naming is different, I just copied the whole structure and made it work with VSTS!

Second, I do not intend on accepting a dependency on another package here. Please consolidate into this PR if needed.

Ok, Do you want default items within your repo or within the SDK itself?

[clairernovotny]

Default items can be in this SDK itself. It should be a "one stop" resource. I still need the structure to be closer to this one in order to do PR reviews. I'm okay with renaming the top level directories to Source, Samples, etc, but that should be its own PR without any other content changes so that it's trackable.

[Nirmal4G]

Ok, I'll redo the PR into 3 ways.

1. Restructure the current changes (file/folder change)
2. Apply cosmetics (whitespace change)
3. Put mine on top of the above changes (code changes)

Is that ok?

[clairernovotny]

Sounds like a plan, but what do you mean by "cosmetics"?

[Nirmal4G]

.editorconfig

[clairernovotny]

That's fine...but the .editorconfig should be this one: https://github.com/onovotny/SignService/blob/master/.editorconfig

[clairernovotny]

Are you going to be submitting three new PR's to mach the above? I'm happy to merge them fairly quickly after a reiew.

[Nirmal4G]

Yep.

[Nirmal4G]

Closed in favour of #80