Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cleanup - Package Structure #79

Merged
merged 6 commits into from
Jun 1, 2018
Merged

Spring Cleanup - Package Structure #79

merged 6 commits into from
Jun 1, 2018

Conversation

Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented May 31, 2018

Split from #72. Continued from #78.

for drop in upgrade
'parameters' should be a part of 'template'
@clairernovotny
Copy link
Collaborator

This is getting rid of the BuildMultiTargeting folder. We need that so it installs into the outer loop...?

@Nirmal4G
Copy link
Contributor Author

Does it not install with just Build folder?

Seen many packages work fine with just Build folder! Is there anyway to test it?

@Nirmal4G
Copy link
Contributor Author

Will add redirections back to the Build folder, if it doesn't work with the outer loop.

Structure closely matches what I have currently without any code change
@Nirmal4G
Copy link
Contributor Author

This is done. You can merge anytime.

in all files with rules from editor config
@clairernovotny
Copy link
Collaborator

There are a lot of changes here -- can you please highlight what they are (and why)?

@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented Jun 1, 2018

None of these are code changes, only cosmetics and restructure, so that my original PR can be added on top of this.

@clairernovotny clairernovotny merged commit 050ba78 into novotnyllc:master Jun 1, 2018
@Nirmal4G Nirmal4G deleted the pr/cleanup-code branch June 1, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants