Add module t1k/build #9625
Open
Add module t1k/build #9625
+572
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famosab
reviewed
Jan 12, 2026
Contributor
famosab
left a comment
famosab
left a comment
There was a problem hiding this comment.
Looks good just one small request :)
Contributor
There was a problem hiding this comment.
Can you rename this to nextflow.config? That is what we advise to do :)
|
|
||
| test("homo_sapiens - kir") { | ||
|
|
||
| config "./download.config" |
Contributor
There was a problem hiding this comment.
Suggested change
| config "./download.config" | |
| config "./nextflow.config" |
|
|
||
| test("homo_sapiens - kir - stub") { | ||
|
|
||
| config "./download.config" |
Contributor
There was a problem hiding this comment.
Suggested change
| config "./download.config" | |
| config "./nextflow.config" |
Comment on lines
+81
to
+82
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.fasta' ,checkIfExists: true), | ||
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.gtf' ,checkIfExists: true) |
Contributor
There was a problem hiding this comment.
Suggested change
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.fasta' ,checkIfExists: true), | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.gtf' ,checkIfExists: true) | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.fasta', checkIfExists: true), | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.gtf', checkIfExists: true) |
Comment on lines
+111
to
+112
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.fasta' ,checkIfExists: true), | ||
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.gtf' ,checkIfExists: true) |
Contributor
There was a problem hiding this comment.
Suggested change
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.fasta' ,checkIfExists: true), | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.gtf' ,checkIfExists: true) | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.fasta', checkIfExists: true), | |
| file(params.modules_testdata_base_path + 'genomics/homo_sapiens/genome/genome.gtf', checkIfExists: true) |
Comment on lines
+14
to
+18
| tuple val(meta), path("*_rna_seq.fa") , optional: true, emit: rna_sequences | ||
| tuple val(meta), path("*_dna_seq.fa") , optional: true, emit: dna_sequences | ||
| tuple val(meta), path("*_rna_coord.fa") , optional: true, emit: rna_coordinates | ||
| tuple val(meta), path("*_dna_coord.fa") , optional: true, emit: dna_coordinates | ||
| tuple val(meta), path("*.dat") , optional: true, emit: database |
Contributor
There was a problem hiding this comment.
Suggested change
| tuple val(meta), path("*_rna_seq.fa") , optional: true, emit: rna_sequences | |
| tuple val(meta), path("*_dna_seq.fa") , optional: true, emit: dna_sequences | |
| tuple val(meta), path("*_rna_coord.fa") , optional: true, emit: rna_coordinates | |
| tuple val(meta), path("*_dna_coord.fa") , optional: true, emit: dna_coordinates | |
| tuple val(meta), path("*.dat") , optional: true, emit: database | |
| tuple val(meta), path("*_rna_seq.fa") , optional: true, emit: rna_sequences | |
| tuple val(meta), path("*_dna_seq.fa") , optional: true, emit: dna_sequences | |
| tuple val(meta), path("*_rna_coord.fa"), optional: true, emit: rna_coordinates | |
| tuple val(meta), path("*_dna_coord.fa"), optional: true, emit: dna_coordinates | |
| tuple val(meta), path("*.dat") , optional: true, emit: database |
| def ena_args = ena ? "-d ${ena}" : '' | ||
| def fasta_args = fasta ? "-f ${fasta}" : '' | ||
| def annotation_args = annotation ? "-g ${annotation}" : '' | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #7963
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda