Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mitohifi container and switch to nf-test #7770

Merged
merged 11 commits into from
Mar 11, 2025

Conversation

prototaxites
Copy link
Contributor

Updates mitohifi container to new build without conda defaults channel. Bump to nf-test because why not :)

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@prototaxites
Copy link
Contributor Author

Getting the below linting errors. Not sure if need to be fixed or can be ignored - discussion on Slack suggests the latter maybe?

https://nfcore.slack.com/archives/CE6PELWR4/p1725867108827219

╭─ [!] 2 Module Test Warnings ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                    ╷                                           ╷                                                                                                                             │
│ Module name        │ File path                                 │ Test message                                                                                                                │
│╶───────────────────┼───────────────────────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╴│
│ mitohifi/mitohifi  │ modules/nf-core/mitohifi/mitohifi/main.nf │ Unable to connect to container registry, code:  405, url: https://ghcr.io/marcelauliano/mitohifi:3.2.3                      │
│ mitohifi/mitohifi  │ modules/nf-core/mitohifi/mitohifi/main.nf │ Container versions do not match                                                                                             │
│                    ╵                                           ╵                                                                                                                             │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

@prototaxites
Copy link
Contributor Author

prototaxites commented Mar 11, 2025

Looks like the version number internally to mitohifi has not been bumped with the new release - have switched out to use a fixed version number for now.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add stubs and stub tests please.

@prototaxites
Copy link
Contributor Author

Done - looks like it's ready to go unless anything else needs changed?

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me, thanks for adding nf-test and the snapshots :)

@SPPearce SPPearce added this pull request to the merge queue Mar 11, 2025
Merged via the queue into nf-core:master with commit 45bd069 Mar 11, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-test migration: mitohifi/mitohifi nf-test migration: mitohifi/findmitoreference
2 participants