-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mitohifi container and switch to nf-test #7770
Conversation
Getting the below linting errors. Not sure if need to be fixed or can be ignored - discussion on Slack suggests the latter maybe? https://nfcore.slack.com/archives/CE6PELWR4/p1725867108827219
|
Looks like the version number internally to mitohifi has not been bumped with the new release - have switched out to use a fixed version number for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add stubs and stub tests please.
Done - looks like it's ready to go unless anything else needs changed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good to me, thanks for adding nf-test and the snapshots :)
Updates mitohifi container to new build without conda defaults channel. Bump to nf-test because why not :)
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda