RFC: document GPU container variants in meta.yml (ribodetector)#11259
Draft
pinin4fjords wants to merge 2 commits intomasterfrom
Draft
RFC: document GPU container variants in meta.yml (ribodetector)#11259pinin4fjords wants to merge 2 commits intomasterfrom
pinin4fjords wants to merge 2 commits intomasterfrom
Conversation
Update GPU container from PyTorch 1.11.0 (CUDA 11.1, March 2022) to PyTorch 2.10.0 (CUDA 12.9) and pin cuda-version>=12,<13 in environment.gpu.yml to keep the solver within supported CUDA versions. The old GPU container used PyTorch 1.11.0 because it was the last version whose conda dependencies did not require the __cuda virtual package, which is absent on Wave's GPU-less build servers. Wave now handles this automatically via a two-pass solve (seqeralabs/wave#1027), so we can build containers with current PyTorch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extend the meta.yml containers block with CUDA-versioned platform keys so pipeline developers have pre-built URIs documented when they need to offer users a choice of GPU container. The `+cuda12`/`+cuda11` suffix convention is new; opening this as an RFC to gather feedback on naming before wider rollout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: GPU container variants in `meta.yml`
Opened as a draft/RFC. Depends on #11258 (the non-controversial container bump) landing first, since the new URIs referenced here match that PR's build.
GPU containers are tied to a CUDA major version (full forward compat within each, so only a couple of variants matter in practice). This PR proposes extending the existing `containers` block (see fastqc, multiqc) with CUDA-versioned platform keys so that pipeline developers have pre-built URIs documented when they need to offer users a choice:
```yaml
containers:
docker:
linux/amd64: ...
linux/arm64: ...
linux/amd64+cuda12: ... # default GPU container
linux/amd64+cuda11: ... # alternative for older drivers
singularity:
linux/amd64: ...
linux/arm64: ...
linux/amd64+cuda12: ...
linux/amd64+cuda11: ...
```
The `+cuda12`/`+cuda11` suffix convention is new. Open to feedback on the naming and on whether this belongs in `meta.yml` at all versus a separate doc mechanism.
Related