Skip to content

bots add new module for svdss/index#11253

Open
vagkaratzas wants to merge 5 commits intomasterfrom
add-SVDSS_INDEX
Open

bots add new module for svdss/index#11253
vagkaratzas wants to merge 5 commits intomasterfrom
add-SVDSS_INDEX

Conversation

@vagkaratzas
Copy link
Copy Markdown
Contributor

@vagkaratzas vagkaratzas commented Apr 21, 2026

PR checklist

Closes #11244

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@vagkaratzas
Copy link
Copy Markdown
Contributor Author

@Krannich479 I went ahead and gave this a shot for a demo. Since you opened the issue and hopefully have the domain knowledge, could you review and verify that everything is in place as it should?

Copy link
Copy Markdown
Contributor

@Krannich479 Krannich479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this over!

Comment thread modules/nf-core/svdss/index/main.nf
Comment thread modules/nf-core/svdss/index/main.nf
Comment thread modules/nf-core/svdss/index/main.nf
Comment thread modules/nf-core/svdss/index/meta.yml Outdated
Copy link
Copy Markdown
Contributor

@Krannich479 Krannich479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vagkaratzas
Copy link
Copy Markdown
Contributor Author

@Krannich479 I made another round of updates, can you make a sanity check before we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: SVDSS/INDEX

3 participants