Open
Conversation
772c7c8 to
0953def
Compare
0953def to
a2aff07
Compare
akaviaLab
reviewed
Apr 20, 2026
Contributor
akaviaLab
left a comment
There was a problem hiding this comment.
In general, looks good to me, but I have some comments. I'd suggest getting one of the core maintainers to look at it.
famosab
reviewed
Apr 21, 2026
Contributor
famosab
left a comment
There was a problem hiding this comment.
Thank you for your contribution to nf-core! I added a few comments to your PR. :)
Contributor
|
I think you're not supposed to gave ontologies in the meta parts of a
tuple. AFAIK, the groovy maps don't need it.
Apart from that, looks good to me!
…On Tue, 21 Apr 2026, 10:31 pm Erin McAuley, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On modules/nf-core/parsnp/meta.yml
<#11196?email_source=notifications&email_token=ACQYYZUSEKEIMFA2WDDCL4L4W7SCJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJVGA4DQMBZGA3KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJL3QOJPXEZLWNFSXOX3DNRUWG2Y#discussion_r3120411137>
:
updated!
—
Reply to this email directly, view it on GitHub
<#11196?email_source=notifications&email_token=ACQYYZT73BY2OVF7D6WFIQD4W7SCJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJVGA4DQMBZGA3KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJPLQOJPXEZLWNFSXOX3ON52GSZTJMNQXI2LPNZZV6Y3MNFRWW#discussion_r3120411137>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQYYZSD2RW4JECORIFKXB34W7SCJAVCNFSM6AAAAACX2KX632VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCNJQHA4DAOJQGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
famosab
reviewed
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #8614.
This PR adds a new
parsnpmodule and tests. The test is a bit contrived because I'm using the same FASTA files but I think it is sufficient -- I can also add some more complex test cases if preferred.topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda