Force include locations #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax the location_min_seq_days as many important countries have quite some delay but are still informative/important
corneliusroemer
force-pushed
the
feat/force-include-locations
branch
from
db423bb
to
4f87674
Compare
|
Can you look at this @trvrb, @joverlee521, @jameshadfield? It would be nice to have some important countries force included. Current country selection has nothing from South America nor from Africa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Current include/exclude settings don't allow for countries to be force included.
This PR adds that ability in a symmetrical way to exclude.
Because we of course don't want to force include countries that have very little data, a force include is ignored if it satisfies the normal include by <10%.
I guess instead of having a simple force include, one could have a dict that allows certain countries to have a laxer include requirement: e.g. Brazil could be included if it has at least 40% of the required sequences of non-force included countries.
I played a bit with settings and these seem quite reasonable to me. Notably, we should extend the window within which min-seqs are counted as many very important countries (India, South Africa, Brazil) produce sequences with a significant delay. That doesn't make them unuseful for the analysis, I don't think we should be as strict as we currently are.
Here's how the new settings would look:
