-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: simplify mime-type checks to support jpg and other image formats #2401
Conversation
…2399 Signed-off-by: Kostiantyn Miakshyn <[email protected]>
40010de
to
fa0067f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
=======================================
Coverage ? 42.86%
Complexity ? 854
=======================================
Files ? 72
Lines ? 3201
Branches ? 0
=======================================
Hits ? 1372
Misses ? 1829
Partials ? 0 |
/backport to stable4 |
@Koc I think we need some adjustments in the backport as we have the duplicated endpoints there. |
I've re-tested it one more time: Created a form with file question type. Allowed images + pdf.
@Chartman123 I can backport changes manualy once we merged this one. Let's merge? |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR should fix #2399
TODO: