Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable4] fix: simplify mime-type checks to support jpg and other image formats #2422

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 19, 2024

Backport of PR #2401

@backportbot backportbot bot requested review from Chartman123 and Koc November 19, 2024 18:28
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Nov 19, 2024
@backportbot backportbot bot added this to the 4.3.4 milestone Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable4@7587b57). Learn more about missing BASE report.
Report is 1 commits behind head on stable4.

Additional details and impacted files
@@            Coverage Diff             @@
##             stable4    #2422   +/-   ##
==========================================
  Coverage           ?   35.45%           
  Complexity         ?     1032           
==========================================
  Files              ?       71           
  Lines              ?     3923           
  Branches           ?        0           
==========================================
  Hits               ?     1391           
  Misses             ?     2532           
  Partials           ?        0           
---- 🚨 Try these New Features:

@Chartman123
Copy link
Collaborator

Chartman123 commented Nov 19, 2024

@Koc you can add the adjustments into this PR :)

@Koc
Copy link
Collaborator

Koc commented Nov 19, 2024

Everything is fine for me. Just tested it on local env

🔍 Preview

image

image

@Chartman123
Copy link
Collaborator

Chartman123 commented Nov 20, 2024

@Koc yes it will work. Our front-end only uses the new routes. But please add your change at uploadFiles() in ApiController also to uploadFilesLegacy().

This is required if someone uses our deprecated API.

@Koc Koc force-pushed the backport/2401/stable4 branch from a3d545c to d1360f0 Compare November 20, 2024 16:57
@Koc
Copy link
Collaborator

Koc commented Nov 20, 2024

ah, got it. @Chartman123 I've added change to uploadFilesLegacy as well.

@susnux susnux merged commit 270fc5a into stable4 Nov 20, 2024
49 checks passed
@susnux susnux deleted the backport/2401/stable4 branch November 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants