Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate cos^2 - sin^2 in model #42

Merged
merged 5 commits into from
Feb 17, 2025
Merged

calculate cos^2 - sin^2 in model #42

merged 5 commits into from
Feb 17, 2025

Conversation

KyleQianliMa
Copy link
Collaborator

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@KyleQianliMa KyleQianliMa marked this pull request as draft February 10, 2025 16:54
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (c219107) to head (9b5d2cc).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #42   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          10       10           
  Lines         806      809    +3     
=======================================
+ Hits          794      797    +3     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyleQianliMa KyleQianliMa changed the title [Draft]calculate cos^2 - sin^2 in model calculate cos^2 - sin^2 in model Feb 14, 2025
@KyleQianliMa KyleQianliMa marked this pull request as ready for review February 14, 2025 16:30
@AndreiSavici AndreiSavici merged commit f1704cf into next Feb 17, 2025
4 checks passed
@AndreiSavici AndreiSavici deleted the cos2_sin2 branch February 17, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants