Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests in view for the new plot options #43

Merged
merged 10 commits into from
Feb 17, 2025
Merged

Conversation

KyleQianliMa
Copy link
Collaborator

@KyleQianliMa KyleQianliMa commented Feb 14, 2025

Short description of the changes:

EWM 9407. Part of the adding plot options are done in #42 experiment setting files. So this PR just add tests to check the plot options are the same as what's intended.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@KyleQianliMa KyleQianliMa marked this pull request as draft February 14, 2025 16:30
@KyleQianliMa KyleQianliMa marked this pull request as ready for review February 17, 2025 14:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (f1704cf) to head (5350cf0).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #43   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          10       10           
  Lines         809      809           
=======================================
  Hits          797      797           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreiSavici AndreiSavici merged commit 75dbd9c into next Feb 17, 2025
3 checks passed
@AndreiSavici AndreiSavici deleted the test_cos2_sin2 branch February 17, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants