Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GSAS option from right click error #80

Open
marshallmcdonnell opened this issue Apr 5, 2017 · 5 comments
Open

Merge GSAS option from right click error #80

marshallmcdonnell opened this issue Apr 5, 2017 · 5 comments
Assignees
Labels
GUI: Bragg / Rietveld Tab The Bragg / Rietveld plotting tab Priority: Low Low priority feature / fix Type: Bug Bug in application; Crashes; Requires break-fix work

Comments

@marshallmcdonnell
Copy link
Member

marshallmcdonnell commented Apr 5, 2017

No description provided.

@marshallmcdonnell
Copy link
Member Author

marshallmcdonnell commented Apr 5, 2017

When I right-click a workspace in Bragg Peak Tab and select Merge GSAS, I get the following error:

Traceback (most recent call last):
  File "/SNS/users/j35/git/FastGR_dev/fastgr/treelib.py", line 306, in do_merge_to_gss
    self._mainWindow.get_workflow.write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
AttributeError: 'function' object has no attribute 'write_gss_file'

@marshallmcdonnell marshallmcdonnell added the Status: Ready Ready for review label Apr 5, 2017
@marshallmcdonnell
Copy link
Member Author

@wdzhou has this fixed in a pull request. Just need to fix other issues and then can merge.

@marshallmcdonnell marshallmcdonnell added Status: In Progress Actively being worked on and removed Status: Ready Ready for review labels Sep 14, 2017
@marshallmcdonnell
Copy link
Member Author

marshallmcdonnell commented Sep 21, 2017

Now, for 6cf9d22 I get the following

Traceback (most recent call last):
  File "/SNS/users/ntm/software/fastgr/FastGR/build/lib/addie/treelib.py", line 306, in do_merge_to_gss
    self._mainWindow.get_workflow.write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
AttributeError: 'function' object has no attribute 'write_gss_file'

@marshallmcdonnell
Copy link
Member Author

marshallmcdonnell commented Nov 2, 2017

For fd6a2c5, I was able to right-click but when I got to save, I get the following:

Traceback (most recent call last):
  File "/SNS/users/ntm/software/fastgr/FastGR/build/lib/addie/treelib.py", line 306, in do_merge_to_gss
    self._mainWindow.get_workflow().write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
  File "/SNS/users/ntm/software/fastgr/FastGR/build/lib/addie/addiedriver.py", line 578, in write_gss_file
    Format='SLOG', Bank=1, Append=append_mode)
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 1050, in algorithm_wrapper
    set_properties(algm, *args, **final_keywords)
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 994, in set_properties
    do_set_property(key, value)
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 986, in do_set_property
    alg_object.setProperty(key, new_value)
ValueError: Invalid value for property InputWorkspace (MatrixWorkspace) "NOM94736tof_bank1": The workspace must have units of TOF

@wdzhou wdzhou added the Type: Bug Bug in application; Crashes; Requires break-fix work label Nov 2, 2017
@marshallmcdonnell
Copy link
Member Author

For master commit 4b7c29e, get the following error when trying to save the test file GSAS_NaNO3_275C.gsa:

SaveGSS-[Notice] SaveGSS started
SaveGSS-[Error] SaveGSS: Failed to open file. Error was: No such file or directory in "('/home/ntm/tests/('/home/ntm/tests/GSAS_NaNO3_275C.gsa', 'GSAS File (*.gsa)')"
SaveGSS-[Error] Error in execution of algorithm SaveGSS:
SaveGSS-[Error] SaveGSS: error (see log)
Traceback (most recent call last):
  File "/home/ntm/direnv/python3/addie/build/lib/addie/treelib.py", line 310, in do_merge_to_gss
    self._mainWindow.get_workflow().write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
  File "/home/ntm/direnv/python3/addie/build/lib/addie/addiedriver.py", line 582, in write_gss_file
    Format='SLOG', Bank=1, Append=append_mode)
  File "/home/ntm/software/mantid/build-master/bin/mantid/simpleapi.py", line 1112, in algorithm_wrapper
    algm.execute()
RuntimeError: SaveGSS: error (see log)

Looks like there is a tuple on the SaveGSS-[Error] SaveGSS: Failed to open file. Error was: No such file or directory in "('/home/ntm/tests/('/home/ntm/tests/GSAS_NaNO3_275C.gsa', 'GSAS File (*.gsa)')" line instead of the filename only.

@marshallmcdonnell marshallmcdonnell added GUI: Bragg / Rietveld Tab The Bragg / Rietveld plotting tab and removed Status: In Progress Actively being worked on labels Sep 30, 2019
@marshallmcdonnell marshallmcdonnell changed the title Bragg Peak Tab - Merge GSAS option from right click error Merge GSAS option from right click error Sep 30, 2019
@marshallmcdonnell marshallmcdonnell added the Priority: Low Low priority feature / fix label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Bragg / Rietveld Tab The Bragg / Rietveld plotting tab Priority: Low Low priority feature / fix Type: Bug Bug in application; Crashes; Requires break-fix work
Projects
None yet
Development

No branches or pull requests

3 participants