-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance on Bragg and PDF's plotting #95
Conversation
The Bragg plotting is working great! Thanks for that. There is one thing that I noticed that is not working in this branch that is still working in the "stable" version. When creating a new workspace via using the docked IPython widget, the workspace tree does not update with the new workspace. Thus, we can't plot up any workspaces we manipulate. The red box and arrows show the unsuccessful update: Just to note, the same is true for the Bragg Peaks tab but this is an issue still in the "stable" version so it shouldn't hold up this merge. |
You were right, the different alpha for same S(Q) but different configurations is a bad idea. Below is 4 different configs with the NOM_96771SQ_3 being an extreme case we would probably never use. Only then do we get enough change to see a difference: Sorry but can we instead try the different line styles mixed with different markers idea? So maybe have the following dictionaries:
and then do combinations when we append a new configuration:
Just an idea though. |
…ze G(r) from same S(q).
Ready for merge. |
This PR implemented line color and style scheme for Bragg plots and PDF plots.
Fixes #75, #81,#85, #95, and #96.
== Test ==
Save S(Q)
a) From tree item
b) From combo box
Edit S(Q) by shifting and scaling from Edit S(Q) dialogue box.
Save G(R) by various file type.