-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming and moving #151
Renaming and moving #151
Conversation
So, I came across this error when trying to load files using the original IDL ui for post-processing: Traceback (most recent call last):
File "/SNS/users/ntm/direnv/python2/addie/build/lib/addie/processing/idl/load_table_intermediate_step_interface.py", line 25, in ok_clicked
self.parent.move_to_folder_step2()
File "build/scripts-2.7/addie", line 2367, in move_to_folder_step2
self.populate_table_clicked()
File "build/scripts-2.7/addie", line 2383, in populate_table_clicked
self.name_search_clicked()
File "build/scripts-2.7/addie", line 2420, in name_search_clicked
o_table.name_search()
AttributeError: TableHandler instance has no attribute 'name_search' It looks like we import two different grep "import TableHandler" scripts/addie Out:
Looking, one has the
Out:
Out:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plotting for the Calculate G(r)
Tab is working as excpected(with any issues already reported as issues prior to these changes) and currently testing the Rietveld
tab.
Currently, crashes for IDL Post-Processing
due to the noted TableHandler
error. Cannot continue with manual testing for this tab. Once this is fixed, I'll continue to test it out and review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plotting for the Calculate G(r)
Tab is working as excpected(with any issues already reported as issues prior to these changes) and currently testing the Rietveld
tab.
Currently, crashes for IDL Post-Processing
due to the noted TableHandler
error. Cannot continue with manual testing for this tab. Once this is fixed, I'll continue to test it out and review.
Going to open separate tickets to address these issues. Namely, issue #162 |
All the work described in #141 has been done.
To test this pull request, simply check the new names of the tabs, play around and make sure is broken.