Accurately trigger the preview slider update based on FPS #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Slider → Preview Camera Updates
Whenever the slider’s value changes, it recomputes and updates the preview camera’s position.
Two Tasks
time.sleep(1/fps)
between updates to pace the animation.Windows Limitation
time.sleep()
on Windows cannot reliably pause for very precise intervals, especially at high frame rates.This PR
Accurate Timing with
time.perf_counter()
1/fps
seconds have passed before applying the next slider change.sleep()
calls in both modes.Future Considerations
Sustaining High FPS
1/fps
-second response times under load? I think this is the bottleneck for current FPS-timer logic.This PR performs better but still jumps given a high FPS.Send–Ack–Send Handshake