Artist discography sorted own-albums-first #2580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort by Artist = Album Artist first, so it shows an artist's own albums first, and appearances on other albums second.
Alias match_album_artist, allows for sorting by an artist's own albums first, then his appearances on compilations/etc.
forgot args in line 89
prettier
prettier
reformatted
removed comment about Subsonic, it's irrelevant since this query is never done through the Subsonic API.
merge upstream changes
Fix EnableMediaFileCoverArt option default value
merge upstream
Upgrade to Go 1.21 (navidrome#2475)
merge upstream
|
Download the artifacts for this pull request: |
|
I think this would be better handled completely on the client. This change is too "hacky" as it depends on "virtual" sort fields. To give some context, I already regret resorting to this in other parts of the code. It makes things too magical. |
|
Allright, I'll have a look if I can do this completely in the WebUI - it may become less magical, but I'm not sure if the result will be more readable... |
this is now done upstream, in metadata/metadata.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2214
This sorts an artist's discography (Artist view) first by his own albums (Artist = Album Artist), then by his appearances (Artist != AlbumArtist).
(this is a re-submit of #2413 - I didn't realise that renaming the branch upstream automatically closes the PR)