-
Notifications
You must be signed in to change notification settings - Fork 3
98 implement usethis tool import linter #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cope with FileNotFoundError
CodSpeed Performance ReportMerging #501 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 97.27% 97.25% -0.03%
==========================================
Files 83 85 +2
Lines 3966 4079 +113
==========================================
+ Hits 3858 3967 +109
- Misses 108 112 +4 ☔ View full report in Codecov by Sentry. |
I think #500 is a pre-requisite to merging because otherwise the warning message here will be repeated multiple times unnecessarily: usethis-python/src/usethis/_tool.py Lines 958 to 964 in 6919a86
|
Based on the changes from #500 it has highlighted another issue - we might have an arbitrary number of config entries - we want to lay claim to a "family" of ConfigEntries all with the prefix This is getting quite complicated, but I think it's the right choice. The So we need a way to register an abstract family of contract entries. |
…, tweak contract name to only include final key
The CI isn't running anymore, rather inexplicitly. It might be because this PR has too many commits against it, so I'll try opening a new PR I think. |
No description provided.