Skip to content

Get performance improvement for dynamic configuration #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nathanjmcdougall opened this issue Apr 7, 2025 · 1 comment · Fixed by #504
Closed

Get performance improvement for dynamic configuration #500

nathanjmcdougall opened this issue Apr 7, 2025 · 1 comment · Fixed by #504
Assignees
@nathanjmcdougall
Labels
enhancement New feature or request

Comments

@nathanjmcdougall
Copy link
Owner

Motivation
For dynamic configuration like for import-linter we are currently computing the config even if we know it won't be added since it already exists. This is because the keys are static, only the values are dynamic.

Summary of desired enhancement
Benchmark this case and improve performance
@nathanjmcdougall nathanjmcdougall added the enhancement New feature or request label Apr 7, 2025
@nathanjmcdougall nathanjmcdougall self-assigned this Apr 7, 2025
@nathanjmcdougall
Copy link
Owner Author

This is actually necessary as a part of #501 because otherwise our is_used checks will also run the dynamic calculation.

@nathanjmcdougall nathanjmcdougall mentioned this issue Apr 7, 2025
Closed
@nathanjmcdougall nathanjmcdougall linked a pull request Apr 7, 2025 that will close this issue
Use lazy definitions for config values #504
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanjmcdougall nathanjmcdougall

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use lazy definitions for config values nathanjmcdougall/usethis-python
1 participant
@nathanjmcdougall