Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Deframer into FrameAccumulator and Router #2900

Closed
wants to merge 33 commits into from

Add first pass at SDDs

99836d6
Select commit
Loading
Failed to load commit list.
Closed

Split Deframer into FrameAccumulator and Router #2900

Add first pass at SDDs
99836d6
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Feb 4, 2025 in 2s

37 new alerts

New alerts in code changed by this pull request

  • 10 warnings
  • 27 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 17 in Svc/Deframer/Deframer.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

compName uses the basic integral type char rather than a typedef with size and signedness.

Check notice on line 25 in Svc/Deframer/Deframer.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

portNum uses the basic integral type int rather than a typedef with size and signedness.

Check notice on line 17 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

compName uses the basic integral type char rather than a typedef with size and signedness.

Check notice on line 28 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

allocationId uses the basic integral type unsigned int rather than a typedef with size and signedness.

Check notice on line 30 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

store_size uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 32 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

recoverable uses the basic integral type bool rather than a typedef with size and signedness.

Check notice on line 34 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

store_size_int uses the basic integral type unsigned int rather than a typedef with size and signedness.

Check notice on line 50 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

portNum uses the basic integral type int rather than a typedef with size and signedness.

Check notice on line 74 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

ringFreeSize uses the basic integral type unsigned int rather than a typedef with size and signedness.

Check notice on line 75 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

serSize uses the basic integral type unsigned int rather than a typedef with size and signedness.

Check notice on line 104 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

ringCapacity uses the basic integral type unsigned int rather than a typedef with size and signedness.

Check notice on line 115 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

size_out uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 71 in Svc/FrameAccumulator/FrameAccumulator.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

m_allocatorId uses the basic integral type unsigned int rather than a typedef with size and signedness.

Check notice on line 18 in Svc/Router/Router.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

compName uses the basic integral type char rather than a typedef with size and signedness.

Check notice on line 26 in Svc/Router/Router.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

portNum uses the basic integral type int rather than a typedef with size and signedness.

Check notice on line 38 in Svc/Router/Router.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

deallocate uses the basic integral type bool rather than a typedef with size and signedness.

Check notice on line 91 in Svc/Router/Router.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

portNum uses the basic integral type int rather than a typedef with size and signedness.

Check warning on line 35 in Svc/Deframer/Deframer.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter context has not been checked.

Check warning on line 35 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter allocator has not been checked.

Check warning on line 35 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter allocationId has not been checked.

Check warning on line 40 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter detector has not been checked.

Check warning on line 54 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter buffer has not been checked.

Check warning on line 57 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter buffer has not been checked.

Check warning on line 61 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter buffer has not been checked.

Check warning on line 138 in Svc/FrameAccumulator/FrameAccumulator.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function
rotate
Loading
is not checked.