Skip to content

Remove Millimetre usage #27059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Mar 12, 2025

This PR changes the following values to Spatium from Millimetre:

  • Stem base length - keeps unit consistent with user length and line width
  • Spacer gap - this was in Spatium already, but was being stored in a Millimetre type.
  • Staff distance - same situation as above

This removes the need to rescale these values when changing spatium size, as the values are scaled when they are used rather than being stored after being scaled.

I have also moved the spacer layout code from its DOM class to TLayout.

@miiizen miiizen changed the title Remove millimetre usage Remove Millimetre usage Mar 12, 2025
@its-not-nice its-not-nice moved this to In Progress in MuseScore Studio 4.6 Mar 12, 2025
@miiizen miiizen requested a review from mike-spa April 22, 2025 12:29
@mike-spa mike-spa merged commit d6ea14d into musescore:master May 6, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore Studio 4.6 May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants