Fix a MSVC compiler warning and multiple build errors #27950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
May 6, 2025
•
Jojo-Schmitz
commented
- Fix MSVC compiler warning reg.: 'score': local variable is initialized but not referenced (C4189)
- Fix build failure, doing changes to read.cpp and measureread.cpp in read460 similar to those in read410, read400, read204 and read114 from Remove Millimetre usage #27059
reg.: 'score': local variable is initialized but not referenced (C4189)
Jojo-Schmitz
changed the title
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
2 times, most recently
from
08741bc to
20d6d75
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
20d6d75 to
45a7d4c
Compare
miiizen
approved these changes
May 6, 2025
|
I wonder about the vtest failures... |
|
That's down to the master branch failing to build! |
mike-spa
approved these changes
May 6, 2025
|
Ah, of course, stupid me ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.