Fix theoretical data race in Inject class #23805
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
("very quickly" as in "keeping the keyboard shortcut pressed so that it fires repeatedly")
Or when quitting app during playback with mixer open
found using Thread Sanitizer
igorkorsukov
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #14790, so should wait on that PR
While concurrent reads don't need protection, and concurrent writes were protected by a mutex, the reads were not protected from the writes, because they didn't have a mutex. That is solved by this PR.
This problem was found using Thread Sanitizer. It is questionable though whether we should try to fix it, because it is unlikely to be a serious problem in practice, and the fix adds some overhead.