Fix data race in AbstractInvoker #23806
Draft
+75
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #23805
This data race was reproducible in Address Sanitizer builds, when you opened and closed the Mixer extremely often and quickly during playback. It is also reported by Thread Sanitizer.
This fix has the risk of introducing deadlocks or performance issues. Before we merge this, we should convince ourselves more that this solution is indeed desirable. I am in contact with Igor to discuss the details, and when we reach a conclusion I will probably post that here.
Like with #23805, it is questionable whether this fix is worth it, even regardless of its correctness and efficiency. The data race that it solves was quite difficult to reproduce (that is, reproduce in such way that the effects were noticeable in the form of an ASan error, and not even a real crash).