Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java (#61) #62

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update java (#61) #62

wants to merge 2 commits into from

Conversation

ao508
Copy link
Collaborator

@ao508 ao508 commented Sep 20, 2024

  • First things first

  • Update to java21


A descriptive title

Briefly describe changes proposed in this pull request:

  • a
  • b

Troubleshooting

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Expected behavior

Actual behavior

Logs, error output, or stacktrace

Steps to reproduce the behavior

Tasks

Include specific tasks in the order they need to be done in. Include links to specific lines of code where the task should happen at.

  • task 1
  • task 2
  • task 3

Crossing T's and dotting I's

Please follow these checklists to help prevent any unexpected issues from being introduced by the changes in this pull request. If an item does not apply then indicate so by surrounding the line item with ~~ to strikethrough the text. See basic writing and formatting syntax for more information.

I. Message handlers checklist:

  • Changes introduced affect the workflow of incoming messages.
  • Messages are following the expected workflow when published to the topic(s) changed or introduced in this pull request.
  • Unit tests were added or updated to ensure messages are handled as expected.

If no unit tests were updated or added, then please explain why: [insert details here]

Please describe how the workflow and messaging was tested/simulated:

Describe your testing environment:

  • NATS [local, local docker, dev server, production]
  • Neo4j [local, local docker, dev server, production]
  • SMILE Server [local, local docker, dev server, production]
  • Message publishing simulation [nats cli, docker nats cli, smile publisher tool, other (describe below)]

Other: [insert details on how messages were published or simulated for testing]

II. Configuration and/or permissions checklist:

  • New topics were introduced.
  • The topics and appropriate permissions were updated in smile-configuration.
  • If applicable, a new account was set up and the account credentials and keys are checked into smile-configuration.
  • Account credentials and keys were shared with the appropriate parties.

Screenshots


General checklist:

  • All requested changes and comments have been resolved.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.

* First things first

Signed-off-by: Angelica Ochoa <[email protected]>

* Update to java21

Signed-off-by: Angelica Ochoa <[email protected]>

---------

Signed-off-by: Angelica Ochoa <[email protected]>
Signed-off-by: Angelica Ochoa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant