Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake refactoring #660

Closed
wants to merge 14 commits into from
Closed

CMake refactoring #660

wants to merge 14 commits into from

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Jan 26, 2025

  • Consistent CMake argument CMAKE_USE_XY
  • Sorted dependencies alphanumerically in storm-config.h and CMakeLists
  • Use MATHSAT instead of MSAT, added FindMathSat script
  • Use STORM_USE_XERCES instead of STORM_XML_SUPPORT

Could have some conflicts with #602

@sjunges
Copy link
Contributor

sjunges commented Feb 18, 2025

Generally, I have included most changes in the refactored CMAKE in the other PR

@volkm
Copy link
Contributor Author

volkm commented Feb 18, 2025

So we should first merge your PR and then see what changes we could still integrate from this PR?

@sjunges sjunges added this to the 1.11 milestone Feb 18, 2025
@sjunges sjunges mentioned this pull request Feb 19, 2025
8 tasks
@sjunges
Copy link
Contributor

sjunges commented Feb 19, 2025

Indeed, I would close it for now for clarity; I think I have covered it (except maybe some order of definitions.. but I am cleaning up things either way)

@sjunges sjunges closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants